linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
	linux-scsi@vger.kernel.org, dave.hansen@linux.intel.com,
	David.Laight@ACULAB.COM, linux-kernel@vger.kernel.org,
	x86@kernel.org
Subject: Re: [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl()
Date: Fri, 25 Nov 2022 22:14:02 -0500	[thread overview]
Message-ID: <yq11qpqmmq4.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20221117232304.1544-1-kirill.shutemov@linux.intel.com> (Kirill A. Shutemov's message of "Fri, 18 Nov 2022 02:23:04 +0300")


Kirill,

> get_user() expects the pointer to be pointer-to-simple-variable type,
> but sic->data is array of 'unsigned char'. It violates get_user()
> contracts.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

  reply	other threads:[~2022-11-26  3:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 23:23 [PATCHv2] scsi: Fix get_user() in call sg_scsi_ioctl() Kirill A. Shutemov
2022-11-26  3:14 ` Martin K. Petersen [this message]
2022-11-28  9:06 ` Kirill A. Shutemov
2022-12-01  3:45 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yq11qpqmmq4.fsf@ca-mkp.ca.oracle.com \
    --to=martin.petersen@oracle.com \
    --cc=David.Laight@ACULAB.COM \
    --cc=dave.hansen@linux.intel.com \
    --cc=jejb@linux.ibm.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).