* [PATCH] [SCSI] esas2r: unlock on error in esas2r_nvram_read_direct()
@ 2019-10-22 10:23 Dan Carpenter
2019-10-25 1:17 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-10-22 10:23 UTC (permalink / raw)
To: Bradley Grove
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, kernel-janitors
This error path is missing an unlock.
Fixes: 26780d9e12ed ("[SCSI] esas2r: ATTO Technology ExpressSAS 6G SAS/SATA RAID Adapter Driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/scsi/esas2r/esas2r_flash.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/esas2r/esas2r_flash.c b/drivers/scsi/esas2r/esas2r_flash.c
index 7bd376d95ed5..b02ac389e6c6 100644
--- a/drivers/scsi/esas2r/esas2r_flash.c
+++ b/drivers/scsi/esas2r/esas2r_flash.c
@@ -1197,6 +1197,7 @@ bool esas2r_nvram_read_direct(struct esas2r_adapter *a)
if (!esas2r_read_flash_block(a, a->nvram, FLS_OFFSET_NVR,
sizeof(struct esas2r_sas_nvram))) {
esas2r_hdebug("NVRAM read failed, using defaults");
+ up(&a->nvram_semaphore);
return false;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [SCSI] esas2r: unlock on error in esas2r_nvram_read_direct()
2019-10-22 10:23 [PATCH] [SCSI] esas2r: unlock on error in esas2r_nvram_read_direct() Dan Carpenter
@ 2019-10-25 1:17 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-10-25 1:17 UTC (permalink / raw)
To: Dan Carpenter
Cc: Bradley Grove, James E.J. Bottomley, Martin K. Petersen,
linux-scsi, kernel-janitors
Dan,
> This error path is missing an unlock.
Applied to 5.5/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-25 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-22 10:23 [PATCH] [SCSI] esas2r: unlock on error in esas2r_nvram_read_direct() Dan Carpenter
2019-10-25 1:17 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).