From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Steffen Maier <maier@linux.ibm.com>,
"James E . J . Bottomley" <jejb@linux.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-s390@vger.kernel.org,
Benjamin Block <bblock@linux.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close
Date: Tue, 01 Oct 2019 14:26:48 -0400 [thread overview]
Message-ID: <yq1tv8stj87.fsf@oracle.com> (raw)
In-Reply-To: <20191001154208.GB3523275@kroah.com> (Greg KH's message of "Tue, 1 Oct 2019 17:42:08 +0200")
Greg,
> Ok, then why make this a module option that you will have to support
> for the next 20+ years anyway if you feel this fix is the correct way
> that it should be done instead?
I agree.
Why not just shut FCP down unconditionally on excessive bit errors?
What's the benefit of allowing things to continue? Are you hoping things
will eventually recover in a single-path scenario?
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-10-01 18:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 16:06 [PATCH] zfcp: fix reaction on bit error theshold notification with adapter close Steffen Maier
[not found] ` <20190925224305.00183208C3@mail.kernel.org>
2019-09-26 11:00 ` Steffen Maier
2019-10-01 3:49 ` Martin K. Petersen
2019-10-01 10:49 ` [PATCH v2] " Steffen Maier
2019-10-01 14:14 ` Greg KH
2019-10-01 15:07 ` Steffen Maier
2019-10-01 15:42 ` Greg KH
2019-10-01 18:26 ` Martin K. Petersen [this message]
2019-10-02 8:31 ` Steffen Maier
2019-10-04 1:47 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq1tv8stj87.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=bblock@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jejb@linux.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=maier@linux.ibm.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).