linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer
       [not found] <20191024025726.GA31421@saurav>
@ 2019-10-24 18:14 ` James Smart
  2019-10-25  1:11 ` Martin K. Petersen
  1 sibling, 0 replies; 2+ messages in thread
From: James Smart @ 2019-10-24 18:14 UTC (permalink / raw)
  To: Saurav Girepunje, dick.kennedy, jejb, martin.petersen,
	linux-scsi, linux-kernel
  Cc: saurav.girepunje, Dick Kennedy

On 10/23/2019 7:57 PM, Saurav Girepunje wrote:
> Replace assignment of 0 to pointer with NULL assignment.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
>   drivers/scsi/lpfc/lpfc_attr.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c
> index ea62322ffe2b..f7df95963a63 100644
> --- a/drivers/scsi/lpfc/lpfc_attr.c
> +++ b/drivers/scsi/lpfc/lpfc_attr.c
> @@ -1641,7 +1641,7 @@ lpfc_set_trunking(struct lpfc_hba *phba, char *buff_out)
>   {
>   	LPFC_MBOXQ_t *mbox = NULL;
>   	unsigned long val = 0;
> -	char *pval = 0;
> +	char *pval = NULL;
>   	int rc = 0;
>   
>   	if (!strncmp("enable", buff_out,

thanks

Reviewed-by: James Smart <james.smart@broadcom.com>

-- james


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer
       [not found] <20191024025726.GA31421@saurav>
  2019-10-24 18:14 ` [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer James Smart
@ 2019-10-25  1:11 ` Martin K. Petersen
  1 sibling, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2019-10-25  1:11 UTC (permalink / raw)
  To: Saurav Girepunje
  Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi,
	linux-kernel, saurav.girepunje


Saurav,

> Replace assignment of 0 to pointer with NULL assignment.

Applied to 5.5/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-10-25  1:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20191024025726.GA31421@saurav>
2019-10-24 18:14 ` [PATCH] scsi: lpfc: lpfc_attr.c: Fix Use plain integer as NULL pointer James Smart
2019-10-25  1:11 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).