From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE294C2D0A3 for ; Mon, 2 Nov 2020 23:05:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA7C222275 for ; Mon, 2 Nov 2020 23:05:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604358335; bh=x+q6Bm5flcZvll36ZgtzcGehsn+wDBCSLDHxqKZxz3E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=bxbohodB/8u7xH89L3AKFfuC6nLpg3pMDbVK+/IrS3UVc0EHZbQvmO+/omjguPXfc 0Isl11NCemgZF2Nznc4p30iNU4sYgnfYHQTkGbg0UvhS2HaPkDBRcYw6gNDM5zGC14 qS62r6k+yzwjdX/Obs/4oBp4QTgolawzptwRSpVM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725940AbgKBXFb (ORCPT ); Mon, 2 Nov 2020 18:05:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:59152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725829AbgKBXFa (ORCPT ); Mon, 2 Nov 2020 18:05:30 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A863F22280; Mon, 2 Nov 2020 23:05:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604358330; bh=x+q6Bm5flcZvll36ZgtzcGehsn+wDBCSLDHxqKZxz3E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Go3NZD3gR76smYAvSHk8Od63rMsSUQ8nQuWTfYp0AcYIhi8yFeTXruNyRqjGJRAT2 TeHnqR7CiHeMaO8zAF7fnPbuMFWxTcR0+J6f/mxsgE3177NvjV2ezB7S0++/Syal9f s6rJP3tmUHx2epSp/Rh9UPXRSE5DO8aDfrE2VMi8= Date: Mon, 2 Nov 2020 15:05:28 -0800 From: Jakub Kicinski To: Marcelo Ricardo Leitner Cc: Petr Malat , linux-sctp@vger.kernel.org, Vlad Yasevich , Neil Horman , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on big-endian platforms Message-ID: <20201102150528.59f13386@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201102132717.GI11030@localhost.localdomain> References: <20201030132633.7045-1-oss@malat.biz> <20201102132717.GI11030@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-sctp@vger.kernel.org On Mon, 2 Nov 2020 10:27:17 -0300 Marcelo Ricardo Leitner wrote: > On Fri, Oct 30, 2020 at 02:26:33PM +0100, Petr Malat wrote: > > Commit 978aa0474115 ("sctp: fix some type cast warnings introduced since > > very beginning")' broke err reading from sctp_arg, because it reads the > > value as 32-bit integer, although the value is stored as 16-bit integer. > > Later this value is passed to the userspace in 16-bit variable, thus the > > user always gets 0 on big-endian platforms. Fix it by reading the __u16 > > field of sctp_arg union, as reading err field would produce a sparse > > warning. > > Makes sense. > > > > > Signed-off-by: Petr Malat > > Then, it also needs: > Fixes: 978aa0474115 ("sctp: fix some type cast warnings introduced since very beginning")' > > Acked-by: Marcelo Ricardo Leitner > (If the maintainers can't add the Fixes tag above, please keep the ack > on the v2) Applied, thanks!