From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
Neil Horman <nhorman@tuxdriver.com>,
Hangbin Liu <liuhangbin@gmail.com>
Subject: Re: [PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer
Date: Sat, 14 Nov 2020 10:40:23 -0300 [thread overview]
Message-ID: <20201114134023.GC3556@localhost.localdomain> (raw)
In-Reply-To: <102788809b554958b13b95d33440f5448113b8d6.1605331373.git.lucien.xin@gmail.com>
On Sat, Nov 14, 2020 at 01:22:53PM +0800, Xin Long wrote:
> A call trace was found in Hangbin's Codenomicon testing with debug kernel:
>
...
>
> So fix it by holding/putting transport instead for proto_unreach_timer
> in transport, just like other timers in transport.
>
> v1->v2:
> - Also use sctp_transport_put() for the "out_unlock:" path in
> sctp_generate_proto_unreach_event(), as Marcelo noticed.
>
> Fixes: 50b5d6ad6382 ("sctp: Fix a race between ICMP protocol unreachable and connect()")
> Reported-by: Hangbin Liu <liuhangbin@gmail.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
next prev parent reply other threads:[~2020-11-14 13:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-14 5:22 [PATCHv2 net] sctp: change to hold/put transport for proto_unreach_timer Xin Long
2020-11-14 13:40 ` Marcelo Ricardo Leitner [this message]
2020-11-14 19:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114134023.GC3556@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=liuhangbin@gmail.com \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).