linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] m4/sctp.m4: make conpatible to autoconf-2.70
@ 2021-01-08 22:22 Sergei Trofimovich
  2021-01-12  2:18 ` Marcelo Ricardo Leitner
  0 siblings, 1 reply; 2+ messages in thread
From: Sergei Trofimovich @ 2021-01-08 22:22 UTC (permalink / raw)
  To: linux-sctp; +Cc: Sergei Trofimovich

On recently released `autoconf-2.70` generated `./configure`
fails as:

```
$ ./configure
...
checking for struct sctp_event_subscribe.sctp_stream_reset_event... yes
checking for gcc options needed to detect all undeclared functions... none needed
./configure: line 16464: syntax error: unexpected end of file
```

This happens becuase new autoconf generates less whitespace:

```
{
if ...
...
fi}
```

It requires at least whitespace between `fi` and `}`.

As input already has newlines the change just drops extra `{}`.

Tested on `autoconf-2.69` and `autoconf-2.70`.

Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
---
 m4/sctp.m4 | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/m4/sctp.m4 b/m4/sctp.m4
index 6593517..94527a6 100644
--- a/m4/sctp.m4
+++ b/m4/sctp.m4
@@ -6,7 +6,7 @@
 
 # Macros to assist on probing kernel features
 #   Probes if a type is defined
-AC_DEFUN([LKSCTP_CHECK_TYPE], [{
+AC_DEFUN([LKSCTP_CHECK_TYPE], [
 AC_CHECK_TYPE([$1],
 	AC_DEFINE([$2], 1,
 		  [Define if $1 is present.])
@@ -22,10 +22,10 @@ AC_CHECK_TYPE([$1],
 #ifdef HAVE_LINUX_SCTP_H
 # include <linux/sctp.h>
 #endif
-])}])
+])])
 
 #   Probes if a struct has a given member
-AC_DEFUN([LKSCTP_CHECK_MEMBER], [{
+AC_DEFUN([LKSCTP_CHECK_MEMBER], [
 AC_CHECK_MEMBER([$1],
 	AC_DEFINE([$2], 1,
 		  [Define if $1 is present.])
@@ -41,10 +41,10 @@ AC_CHECK_MEMBER([$1],
 #ifdef HAVE_LINUX_SCTP_H
 # include <linux/sctp.h>
 #endif
-])}])
+])])
 
 #   Probes if a declaration is present
-AC_DEFUN([LKSCTP_CHECK_DECL], [{
+AC_DEFUN([LKSCTP_CHECK_DECL], [
 AC_CHECK_DECL([$1],
 	AC_DEFINE([$2], 1,
 		  [Define if $1 is present.])
@@ -60,4 +60,4 @@ AC_CHECK_DECL([$1],
 #ifdef HAVE_LINUX_SCTP_H
 # include <linux/sctp.h>
 #endif
-])}])
+])])
-- 
2.30.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] m4/sctp.m4: make conpatible to autoconf-2.70
  2021-01-08 22:22 [PATCH] m4/sctp.m4: make conpatible to autoconf-2.70 Sergei Trofimovich
@ 2021-01-12  2:18 ` Marcelo Ricardo Leitner
  0 siblings, 0 replies; 2+ messages in thread
From: Marcelo Ricardo Leitner @ 2021-01-12  2:18 UTC (permalink / raw)
  To: Sergei Trofimovich; +Cc: linux-sctp

On Fri, Jan 08, 2021 at 10:22:52PM +0000, Sergei Trofimovich wrote:
> On recently released `autoconf-2.70` generated `./configure`
> fails as:
> 
> ```
> $ ./configure
> ...
> checking for struct sctp_event_subscribe.sctp_stream_reset_event... yes
> checking for gcc options needed to detect all undeclared functions... none needed
> ./configure: line 16464: syntax error: unexpected end of file
> ```
> 
> This happens becuase new autoconf generates less whitespace:
> 
> ```
> {
> if ...
> ...
> fi}
> ```
> 
> It requires at least whitespace between `fi` and `}`.
> 
> As input already has newlines the change just drops extra `{}`.
> 
> Tested on `autoconf-2.69` and `autoconf-2.70`.
> 
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

Applied. Thanks Sergei.

  Marcelo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-12  2:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-08 22:22 [PATCH] m4/sctp.m4: make conpatible to autoconf-2.70 Sergei Trofimovich
2021-01-12  2:18 ` Marcelo Ricardo Leitner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).