From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1538C433DB for ; Tue, 23 Mar 2021 08:15:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96D22619B9 for ; Tue, 23 Mar 2021 08:15:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229746AbhCWIPT (ORCPT ); Tue, 23 Mar 2021 04:15:19 -0400 Received: from a.mx.secunet.com ([62.96.220.36]:48946 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbhCWIOt (ORCPT ); Tue, 23 Mar 2021 04:14:49 -0400 Received: from localhost (localhost [127.0.0.1]) by a.mx.secunet.com (Postfix) with ESMTP id B88DE20185; Tue, 23 Mar 2021 09:14:47 +0100 (CET) X-Virus-Scanned: by secunet Received: from a.mx.secunet.com ([127.0.0.1]) by localhost (a.mx.secunet.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vocO-BLmQQ6D; Tue, 23 Mar 2021 09:14:47 +0100 (CET) Received: from cas-essen-01.secunet.de (unknown [10.53.40.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by a.mx.secunet.com (Postfix) with ESMTPS id 5178020184; Tue, 23 Mar 2021 09:14:47 +0100 (CET) Received: from mbx-essen-01.secunet.de (10.53.40.197) by cas-essen-01.secunet.de (10.53.40.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 23 Mar 2021 09:14:47 +0100 Received: from gauss2.secunet.de (10.182.7.193) by mbx-essen-01.secunet.de (10.53.40.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Tue, 23 Mar 2021 09:14:46 +0100 Received: by gauss2.secunet.de (Postfix, from userid 1000) id 72C083180449; Tue, 23 Mar 2021 09:14:46 +0100 (CET) Date: Tue, 23 Mar 2021 09:14:46 +0100 From: Steffen Klassert To: Xin Long CC: , , "Marcelo Ricardo Leitner" , "David S. Miller" Subject: Re: [PATCH ipsec] esp: delete NETIF_F_SCTP_CRC bit from features for esp offload Message-ID: <20210323081446.GN62598@gauss3.secunet.de> References: <5f247a2ef20cae297db4d0a130515d0b7a1b8110.1616139307.git.lucien.xin@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <5f247a2ef20cae297db4d0a130515d0b7a1b8110.1616139307.git.lucien.xin@gmail.com> X-ClientProxiedBy: cas-essen-02.secunet.de (10.53.40.202) To mbx-essen-01.secunet.de (10.53.40.197) X-EXCLAIMER-MD-CONFIG: 2c86f778-e09b-4440-8b15-867914633a10 Precedence: bulk List-ID: X-Mailing-List: linux-sctp@vger.kernel.org On Fri, Mar 19, 2021 at 03:35:07PM +0800, Xin Long wrote: > Now in esp4/6_gso_segment(), before calling inner proto .gso_segment, > NETIF_F_CSUM_MASK bits are deleted, as HW won't be able to do the > csum for inner proto due to the packet encrypted already. > > So the UDP/TCP packet has to do the checksum on its own .gso_segment. > But SCTP is using CRC checksum, and for that NETIF_F_SCTP_CRC should > be deleted to make SCTP do the csum in own .gso_segment as well. > > In Xiumei's testing with SCTP over IPsec/veth, the packets are kept > dropping due to the wrong CRC checksum. > > Reported-by: Xiumei Mu > Fixes: 7862b4058b9f ("esp: Add gso handlers for esp4 and esp6") > Signed-off-by: Xin Long Applied, thanks Xin!