From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A047EC433EF for ; Sat, 9 Apr 2022 06:36:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234128AbiDIGi5 (ORCPT ); Sat, 9 Apr 2022 02:38:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40420 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231337AbiDIGi5 (ORCPT ); Sat, 9 Apr 2022 02:38:57 -0400 Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 26C2318C0D9 for ; Fri, 8 Apr 2022 23:36:50 -0700 (PDT) Received: by mail-ej1-x633.google.com with SMTP id bq8so21099174ejb.10 for ; Fri, 08 Apr 2022 23:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=malat-biz.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QIadV+02aife5O5acIeg03pteZkbniQhtMavKParwPo=; b=4TrE0p8nGdolXnaaBW8lx2AsYPF74Q+Ek8ggEGCM/y6gRyKGD2olfAfb5oBe/zf4om s8Rf/FT+ZnJzY+/SVvC0BM/Cqn8DSzFWM4p+gFqA+/RteBXJtbeL7GqFDxc3zsz9WrNk JoefpChTrqpQv+XBt2iDbnPr9ZVy8Xj3tduqY1Mjhh2LAtJCIVekq00fYXQPmlP/U/pF rRZSEoKAeVQ3VEvFZ54jrfP9udoAuzEx7Tpi6x3OR8zU1t9gtdmfeIxgB2kym9NsMR54 IiYaOM4Fi7n/kBP+4/sTKvldkMMaf4tZVkBt6xg66sHfj/st+C6ZokGXFn79fDLgN8gz bK2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QIadV+02aife5O5acIeg03pteZkbniQhtMavKParwPo=; b=yNwTGLZCtb2dWxtRN/No5wHMpMpMIzTk59AsJ9ZELlazRo3PzGwdEBqeTnrTsM1Z5z UZ8DYJlHSwlDohrqaBHrwWHlhUCibX5h5vrcsYaUL2FUgQBe+WGT5DSS6GpfoFFXqMWb I/DVdRcY7bM2UMoB9YQv/ExbqHpWUZR7RCaRJHXlL42PEhPFFz6c9+0Dq9R26vchkNbv lJo3p1ktvLSRnQC/wc0+ZEhXvUUIdStpVOERGub/gcRG96bXA+kZeHh0YKmqNKRcx5rI 4Md50SX+HVVyI7JMP1rql6iS4d/O7TPWHM9VEd4WNrlBMFzxafIMMrcRJH5WhIPqtwet 5i8w== X-Gm-Message-State: AOAM532S/rxBhjxWDc/Rv9ZmxDQdeKMnvVqvaYZvf5JegJL060e9HYbU 1POhfoV5vgwzTym2aqH8AtvEhw== X-Google-Smtp-Source: ABdhPJw15MeLiCGc0ArY7J1Zn7ZYjAL0lhyP5omP3RmpQKrGvXdnKG3V7Ai9Uslk1sgeD/tWB4tPSQ== X-Received: by 2002:a17:907:3f18:b0:6e0:df2d:c76a with SMTP id hq24-20020a1709073f1800b006e0df2dc76amr22280753ejc.55.1649486208717; Fri, 08 Apr 2022 23:36:48 -0700 (PDT) Received: from ntb.petris.klfree.czf ([2a02:8070:d4c1:3a00:ceb5:41c:b517:660f]) by smtp.googlemail.com with ESMTPSA id m3-20020a17090679c300b006cf9ce53354sm9381437ejo.190.2022.04.08.23.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Apr 2022 23:36:48 -0700 (PDT) From: Petr Malat To: netdev@vger.kernel.org Cc: Vlad Yasevich , Neil Horman , "David S. Miller" , Jakub Kicinski , linux-sctp@vger.kernel.org, Petr Malat , Marcelo Ricardo Leitner Subject: [PATCH] sctp: Initialize daddr on peeled off socket Date: Sat, 9 Apr 2022 08:36:11 +0200 Message-Id: <20220409063611.673193-1-oss@malat.biz> X-Mailer: git-send-email 2.30.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-sctp@vger.kernel.org Function sctp_do_peeloff() wrongly initializes daddr of the original socket instead of the peeled off socket, which makes getpeername() return zeroes instead of the primary address. Initialize the new socket instead. Fixes: d570ee490fb1 ("[SCTP]: Correctly set daddr for IPv6 sockets during peeloff") Signed-off-by: Petr Malat Acked-by: Marcelo Ricardo Leitner --- net/sctp/socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sctp/socket.c b/net/sctp/socket.c index 3e1a9600be5e..7b0427658056 100644 --- a/net/sctp/socket.c +++ b/net/sctp/socket.c @@ -5636,7 +5636,7 @@ int sctp_do_peeloff(struct sock *sk, sctp_assoc_t id, struct socket **sockp) * Set the daddr and initialize id to something more random and also * copy over any ip options. */ - sp->pf->to_sk_daddr(&asoc->peer.primary_addr, sk); + sp->pf->to_sk_daddr(&asoc->peer.primary_addr, sock->sk); sp->pf->copy_ip_options(sk, sock->sk); /* Populate the fields of the newsk from the oldsk and migrate the -- 2.30.2