From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Gustavo A. R. Silva" <gustavoars@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Kees Cook <keescook@chromium.org>,
linux-kernel@vger.kernel.org, x86@kernel.org,
dm-devel@redhat.com, linux-m68k@lists.linux-m68k.org,
linux-mips@vger.kernel.org, linux-s390@vger.kernel.org,
kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-btrfs@vger.kernel.org,
linux-can@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux1394-devel@lists.sourceforge.net, io-uring@vger.kernel.org,
lvs-devel@vger.kernel.org, linux-mtd@lists.infradead.org,
kasan-dev@googlegroups.com, linux-mmc@vger.kernel.org,
nvdimm@lists.linux.dev, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-perf-users@vger.kernel.org,
linux-raid@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-usb@vger.kernel.org,
virtualization@lists.linux-foundation.org,
v9fs-developer@lists.sourceforge.net, linux-rdma@vger.kernel.org,
alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members
Date: Tue, 28 Jun 2022 10:36:51 -0300 [thread overview]
Message-ID: <20220628133651.GO23621@ziepe.ca> (raw)
In-Reply-To: <20220628022129.GA8452@embeddedor>
On Tue, Jun 28, 2022 at 04:21:29AM +0200, Gustavo A. R. Silva wrote:
> > > Though maybe we could just switch off -Wgnu-variable-sized-type-not-at-end during configuration ?
> We need to think in a different strategy.
I think we will need to switch off the warning in userspace - this is
doable for rdma-core.
On the other hand, if the goal is to enable the array size check
compiler warning I would suggest focusing only on those structs that
actually hit that warning in the kernel. IIRC infiniband doesn't
trigger it because it just pointer casts the flex array to some other
struct.
It isn't actually an array it is a placeholder for a trailing
structure, so it is never indexed.
This is also why we hit the warning because the convient way for
userspace to compose the message is to squash the header and trailer
structs together in a super struct on the stack, then invoke the
ioctl.
Jason
next prev parent reply other threads:[~2022-06-28 13:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-27 18:04 [PATCH][next] treewide: uapi: Replace zero-length arrays with flexible-array members Gustavo A. R. Silva
2022-06-27 18:27 ` Daniel Borkmann
2022-06-27 18:35 ` Gustavo A. R. Silva
2022-06-28 0:40 ` Jason Gunthorpe
2022-06-28 0:58 ` Gustavo A. R. Silva
2022-06-28 2:21 ` Gustavo A. R. Silva
2022-06-28 13:36 ` Jason Gunthorpe [this message]
2022-06-28 13:56 ` Gustavo A. R. Silva
2022-06-28 17:54 ` Kees Cook
2022-06-28 18:44 ` Jason Gunthorpe
2022-06-27 19:53 ` Stephen Hemminger
2022-06-28 14:18 ` Gustavo A. R. Silva
2022-06-27 22:31 ` Dan Williams
2022-06-28 7:27 ` Geert Uytterhoeven
2022-06-28 18:05 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220628133651.GO23621@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=alsa-devel@alsa-project.org \
--cc=bpf@vger.kernel.org \
--cc=coreteam@netfilter.org \
--cc=daniel@iogearbox.net \
--cc=dm-devel@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavoars@kernel.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=io-uring@vger.kernel.org \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux-usb@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=lvs-devel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=nvdimm@lists.linux.dev \
--cc=target-devel@vger.kernel.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).