From: Shannon Nelson <snelson@pensando.io> To: Alexander Duyck <alexander.duyck@gmail.com>, Xin Long <lucien.xin@gmail.com> Cc: network dev <netdev@vger.kernel.org>, "linux-sctp @ vger . kernel . org" <linux-sctp@vger.kernel.org>, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>, Neil Horman <nhorman@tuxdriver.com>, David Miller <davem@davemloft.net>, Jakub Kicinski <kuba@kernel.org>, Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, intel-wired-lan <intel-wired-lan@lists.osuosl.org> Subject: Re: [PATCH net-next 1/6] net: add inline function skb_csum_is_sctp Date: Tue, 19 Jan 2021 15:35:14 -0800 [thread overview] Message-ID: <41658acb-6607-8b4c-d29d-f71892434e0b@pensando.io> (raw) In-Reply-To: <CAKgT0UduX4M-N1Kyo-M2=05EO_rAs2c_CDrUwWMKk2oDOgxd2Q@mail.gmail.com> On 1/19/21 2:23 PM, Alexander Duyck wrote: > On Fri, Jan 15, 2021 at 10:13 PM Xin Long <lucien.xin@gmail.com> wrote: >> This patch is to define a inline function skb_csum_is_sctp(), and >> also replace all places where it checks if it's a SCTP CSUM skb. >> This function would be used later in many networking drivers in >> the following patches. >> >> Suggested-by: Alexander Duyck <alexander.duyck@gmail.com> >> Signed-off-by: Xin Long <lucien.xin@gmail.com> > One minor nit. If you had to resubmit this I might move the ionic > driver code into a separate patch. However It can probably be accepted > as is. > > Reviewed-by: Alexander Duyck <alexanderduyck@fb.com> Alex has a good point - if you repost, please split out the ionic bits to a separate patch. Either way, for ionic: Acked-by: Shannon Nelson <snelson@pensando.io> >> --- >> drivers/net/ethernet/pensando/ionic/ionic_txrx.c | 2 +- >> include/linux/skbuff.h | 5 +++++ >> net/core/dev.c | 2 +- >> 3 files changed, 7 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c >> index ac4cd5d..162a1ff 100644 >> --- a/drivers/net/ethernet/pensando/ionic/ionic_txrx.c >> +++ b/drivers/net/ethernet/pensando/ionic/ionic_txrx.c >> @@ -979,7 +979,7 @@ static int ionic_tx_calc_csum(struct ionic_queue *q, struct sk_buff *skb) >> stats->vlan_inserted++; >> } >> >> - if (skb->csum_not_inet) >> + if (skb_csum_is_sctp(skb)) >> stats->crc32_csum++; >> else >> stats->csum++; >> diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h >> index c9568cf..46f901a 100644 >> --- a/include/linux/skbuff.h >> +++ b/include/linux/skbuff.h >> @@ -4621,6 +4621,11 @@ static inline void skb_reset_redirect(struct sk_buff *skb) >> #endif >> } >> >> +static inline bool skb_csum_is_sctp(struct sk_buff *skb) >> +{ >> + return skb->csum_not_inet; >> +} >> + >> static inline void skb_set_kcov_handle(struct sk_buff *skb, >> const u64 kcov_handle) >> { >> diff --git a/net/core/dev.c b/net/core/dev.c >> index 0a31d4e..bbd306f 100644 >> --- a/net/core/dev.c >> +++ b/net/core/dev.c >> @@ -3617,7 +3617,7 @@ static struct sk_buff *validate_xmit_vlan(struct sk_buff *skb, >> int skb_csum_hwoffload_help(struct sk_buff *skb, >> const netdev_features_t features) >> { >> - if (unlikely(skb->csum_not_inet)) >> + if (unlikely(skb_csum_is_sctp(skb))) >> return !!(features & NETIF_F_SCTP_CRC) ? 0 : >> skb_crc32c_csum_help(skb); >> >> -- >> 2.1.0 >>
next prev parent reply other threads:[~2021-01-19 23:37 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-16 6:13 [PATCH net-next 0/6] net: support SCTP CRC csum offload for tunneling packets in some drivers Xin Long 2021-01-16 6:13 ` [PATCH net-next 1/6] net: add inline function skb_csum_is_sctp Xin Long 2021-01-16 6:13 ` [PATCH net-next 2/6] net: igb: use skb_csum_is_sctp instead of protocol check Xin Long 2021-01-16 6:13 ` [PATCH net-next 3/6] net: igbvf: " Xin Long 2021-01-16 6:13 ` [PATCH net-next 4/6] net: igc: " Xin Long 2021-01-16 6:13 ` [PATCH net-next 5/6] net: ixgbe: " Xin Long 2021-01-16 6:13 ` [PATCH net-next 6/6] net: ixgbevf: " Xin Long 2021-01-19 22:25 ` Alexander Duyck 2021-01-19 22:25 ` [PATCH net-next 5/6] net: ixgbe: " Alexander Duyck 2021-01-19 22:24 ` [PATCH net-next 4/6] net: igc: " Alexander Duyck 2021-01-19 22:24 ` [PATCH net-next 3/6] net: igbvf: " Alexander Duyck 2021-01-19 22:24 ` [PATCH net-next 2/6] net: igb: " Alexander Duyck 2021-01-19 22:23 ` [PATCH net-next 1/6] net: add inline function skb_csum_is_sctp Alexander Duyck 2021-01-19 23:35 ` Shannon Nelson [this message] 2021-01-19 23:40 ` [PATCH net-next 0/6] net: support SCTP CRC csum offload for tunneling packets in some drivers patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=41658acb-6607-8b4c-d29d-f71892434e0b@pensando.io \ --to=snelson@pensando.io \ --cc=alexander.duyck@gmail.com \ --cc=anthony.l.nguyen@intel.com \ --cc=davem@davemloft.net \ --cc=intel-wired-lan@lists.osuosl.org \ --cc=jesse.brandeburg@intel.com \ --cc=kuba@kernel.org \ --cc=linux-sctp@vger.kernel.org \ --cc=lucien.xin@gmail.com \ --cc=marcelo.leitner@gmail.com \ --cc=netdev@vger.kernel.org \ --cc=nhorman@tuxdriver.com \ --subject='Re: [PATCH net-next 1/6] net: add inline function skb_csum_is_sctp' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).