archive mirror
 help / color / mirror / Atom feed
From: Xin Long <>
To: network dev <>,,,
	Marcelo Ricardo Leitner <>,
Cc: David Laight <>
Subject: [PATCH net-next 2/2] sctp: send the next probe immediately once the last one is acked
Date: Thu, 24 Jun 2021 11:48:09 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

These is no need to wait for 'interval' period for the next probe
if the last probe is already acked in search state. The 'interval'
period waiting should be only for probe failure timeout and the
current pmtu check when it's in search complete state.

This change will shorten the probe time a lot in search state, and
also fix the document accordingly.

Signed-off-by: Xin Long <>
 Documentation/networking/ip-sysctl.rst | 12 ++++++++----
 net/sctp/sm_statefuns.c                |  5 ++++-
 2 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/Documentation/networking/ip-sysctl.rst b/Documentation/networking/ip-sysctl.rst
index 8bff728b3a1e..b3fa522e4cd9 100644
--- a/Documentation/networking/ip-sysctl.rst
+++ b/Documentation/networking/ip-sysctl.rst
@@ -2835,10 +2835,14 @@ encap_port - INTEGER
 	Default: 0
 plpmtud_probe_interval - INTEGER
-        The time interval (in milliseconds) for sending PLPMTUD probe chunks.
-        These chunks are sent at the specified interval with a variable size
-        to probe the mtu of a given path between 2 endpoints. PLPMTUD will
-        be disabled when 0 is set, and other values for it must be >= 5000.
+        The time interval (in milliseconds) for the PLPMTUD probe timer,
+        which is configured to expire after this period to receive an
+        acknowledgment to a probe packet. This is also the time interval
+        between the probes for the current pmtu when the probe search
+        is done.
+        PLPMTUD will be disabled when 0 is set, and other values for it
+        must be >= 5000.
 	Default: 0
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index d29b579da904..09a8f23ec709 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -1275,7 +1275,10 @@ enum sctp_disposition sctp_sf_backbeat_8_3(struct net *net,
+		if (link->pl.state == SCTP_PL_COMPLETE)
+		return sctp_sf_send_probe(net, ep, asoc, type, link, commands);
 	max_interval = link->hbinterval + link->rto;

      parent reply	other threads:[~2021-06-24 15:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-24 15:48 [PATCH net-next 0/2] sctp: make the PLPMTUD probe more effective and efficient Xin Long
2021-06-24 15:48 ` [PATCH net-next 1/2] sctp: do black hole detection in search complete state Xin Long
2021-06-25  1:11   ` Marcelo Ricardo Leitner
2021-06-25 16:23     ` Xin Long
2021-06-24 15:48 ` Xin Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next 2/2] sctp: send the next probe immediately once the last one is acked' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).