From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexei Starovoitov Date: Wed, 22 Jul 2020 17:09:41 +0000 Subject: Re: get rid of the address_space override in setsockopt Message-Id: List-Id: References: <20200720124737.118617-1-hch@lst.de> <20200720204756.iengwcguikj2yrxt@ast-mbp.dhcp.thefacebook.com> <20200722075657.GB26554@lst.de> In-Reply-To: <20200722075657.GB26554@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoph Hellwig Cc: "David S. Miller" , Jakub Kicinski , Alexei Starovoitov , Daniel Borkmann , Alexey Kuznetsov , Hideaki YOSHIFUJI , Eric Dumazet , Linux Crypto Mailing List , LKML , Network Development , bpf , netfilter-devel , coreteam@netfilter.org, linux-sctp@vger.kernel.org, linux-hams@vger.kernel.org, linux-bluetooth@vger.kernel.org, "moderated list:ETHERNET BRIDGE" , linux-can@vger.kernel.org, dccp@vger.kernel.org, linux-decnet-user@lists.sourceforge.net, linux-wpan@vger.kernel.org, linux-s390 , mptcp@lists.01.org, lvs-devel@vger.kernel.org, rds-devel@oss.oracle.com, linux-afs@lists.infradead.org, tipc-discussion@lists.sourceforge.net, linux-x25@vger.kernel.org On Wed, Jul 22, 2020 at 12:56 AM Christoph Hellwig wrote: > > On Mon, Jul 20, 2020 at 01:47:56PM -0700, Alexei Starovoitov wrote: > > > a kernel pointer. This is something that works for most common sockopts > > > (and is something that the ePBF support relies on), but unfortunately > > > in various corner cases we either don't use the passed in length, or in > > > one case actually copy data back from setsockopt, so we unfortunately > > > can't just always do the copy in the highlevel code, which would have > > > been much nicer. > > > > could you rebase on bpf-next tree and we can route it this way then? > > we'll also test the whole thing before applying. > > The bpf-next tree is missing all my previous setsockopt cleanups, so > there series won't apply. Right. I've realized that after sending that email two days ago. Now bpf-next->net-next PR is pending and as soon as it's merged bpf-next will have all the recent bits.