From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA6C8C433ED for ; Fri, 30 Apr 2021 21:22:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F5356145A for ; Fri, 30 Apr 2021 21:22:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231194AbhD3VXJ (ORCPT ); Fri, 30 Apr 2021 17:23:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231173AbhD3VXI (ORCPT ); Fri, 30 Apr 2021 17:23:08 -0400 Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C0C0C06174A; Fri, 30 Apr 2021 14:22:19 -0700 (PDT) Received: by mail-wr1-x42d.google.com with SMTP id d11so14195282wrw.8; Fri, 30 Apr 2021 14:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EMdVb96Ebtl3ru83rtVmVeThVmQQhiSJu9hUSuKAPiE=; b=Nkqo011c4MJ28xRL/bEr50uVHNQLHa0xUhTdHCypCOOWAJKhDxE9F8d8CGwr/NURzj 41xpYdM6PuV/1cDzkkQfydJfGgJrGhjl1vMfJd54LN1s+c6YIisyn+ELVah9cEwOjSj6 WTZX5asf16wAplvRn4KRnV3u9V/lIFJ8fvfmioDl3igKE0mL9jSmMWj6jPuY2uym+3dM 71xNB4ckNR45vntNYkXJ86j0sQ9G5cI5GrgFiXcWUe+A/k1ePjB11bITvpTV9Oo2bKxk fY+oARIvg63PAV7R0bT3qAi1VKSgHWS+/8gV3NRTyvULhAadM9hKherItXujiPkX7MGw YSmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EMdVb96Ebtl3ru83rtVmVeThVmQQhiSJu9hUSuKAPiE=; b=RbzPfZeSHHmXMz3XqalVlms+GRx0kEaWOCrJehIUq2mCVOc5gTlbU22dKEwH3XzlWt dqq93LRuMa2kUzAefyGXNP31CrJPmO+KIPDmY+4j3DNlI4v7tO9NRJBWLHRd7dJlY5Lf l4IdvDR0yt9YTZXXQ1ZA8lh8+B/i/NGVArocp8ROiVhiJrFXxeDr5TeJN5wgjWIBHP6o Ne0N8Urj1Zo5iillvrnad4F78nQep2xU7UAdKBN7GEPSRUzMNHdNB3wFTOa+A4BI3YHw MkN9NHZZRaPZ2goprw+/XrHteYc+fDgetzDeayfwigQ/FvSkAeqpdoeRPhZOaQr3ZzWS fxhQ== X-Gm-Message-State: AOAM531vKu3QkWYEMMP3GaB4bFwHXQWz8+J0YUgBJCavrSamo5EXMx5Q rEOQOjbiEDNnXm14EVwWOqrTS7BwG4EscbgkqdY= X-Google-Smtp-Source: ABdhPJxaaXYC35dcTvz4io//xzoawObZxmOesdrLcNPGTVuE7cBAYh2mJ1Z0K2NHVCwTWxRUUqBAREqJrByUj3vQDOE= X-Received: by 2002:a5d:4c8a:: with SMTP id z10mr9799959wrs.395.1619817737810; Fri, 30 Apr 2021 14:22:17 -0700 (PDT) MIME-Version: 1.0 References: <1619691589-4776-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1619691589-4776-1-git-send-email-wangyunjian@huawei.com> From: Xin Long Date: Fri, 30 Apr 2021 17:22:06 -0400 Message-ID: Subject: Re: [PATCH net-next] sctp: Remove redundant skb_list null check To: wangyunjian Cc: Jakub Kicinski , davem , Vlad Yasevich , Neil Horman , Marcelo Ricardo Leitner , "linux-sctp @ vger . kernel . org" , network dev , dingxiaoxiong@huawei.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-sctp@vger.kernel.org On Thu, Apr 29, 2021 at 6:20 AM wangyunjian wrote: > > From: Yunjian Wang > > The skb_list cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Yunjian Wang > --- > net/sctp/ulpqueue.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/net/sctp/ulpqueue.c b/net/sctp/ulpqueue.c > index 407fed46931b..6f3685f0e700 100644 > --- a/net/sctp/ulpqueue.c > +++ b/net/sctp/ulpqueue.c > @@ -259,10 +259,7 @@ int sctp_ulpq_tail_event(struct sctp_ulpq *ulpq, struct sk_buff_head *skb_list) > return 1; > > out_free: > - if (skb_list) > - sctp_queue_purge_ulpevents(skb_list); > - else > - sctp_ulpevent_free(event); > + sctp_queue_purge_ulpevents(skb_list); > > return 0; > } > -- > 2.23.0 > Reviewed-by: Xin Long