linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xin Long <lucien.xin@gmail.com>
To: "Leppanen, Jere (Nokia - FI/Espoo)" <jere.leppanen@nokia.com>
Cc: network dev <netdev@vger.kernel.org>,
	"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"kuba@kernel.org" <kuba@kernel.org>,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	"Sverdlin,
	Alexander (Nokia - DE/Ulm)" <alexander.sverdlin@nokia.com>
Subject: Re: [PATCHv2 net 0/3] sctp: always send a chunk with the asoc that it belongs to
Date: Sat, 1 May 2021 14:22:40 -0400	[thread overview]
Message-ID: <CADvbK_eBGFU1dGX+T73HidNT44KZR_Cqd=16YjUfKwcS7AK4sQ@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0702MB38188BD50D8091BC350114EFEC5D9@HE1PR0702MB3818.eurprd07.prod.outlook.com>

On Sat, May 1, 2021 at 12:54 PM Leppanen, Jere (Nokia - FI/Espoo)
<jere.leppanen@nokia.com> wrote:
>
> On Fri, 30 Apr 2021, Xin Long wrote:
>
> > Currently when processing a duplicate COOKIE-ECHO chunk, a new temp
> > asoc would be created, then it creates the chunks with the new asoc.
> > However, later on it uses the old asoc to send these chunks, which
> > has caused quite a few issues.
> >
> > This patchset is to fix this and make sure that the COOKIE-ACK and
> > SHUTDOWN chunks are created with the same asoc that will be used to
> > send them out.
>
> Again, much thanks for looking into this. Patches 1 and 3 are
> almost the same as my patch, which as I mentioned I've been
> testing on and off for the past couple of weeks, and haven't
> found any problems. (Then again, I didn't find any problems last
> time either.)
>
> I think 145cb2f7177d ("sctp: Fix bundling of SHUTDOWN with
> COOKIE-ACK") should not be reverted (I'll reply to the patch).
>
> 12dfd78e3a74 ("sctp: Fix SHUTDOWN CTSN Ack in the peer restart
> case") should be reverted. With association update no longer a
> side effect, we can get CTSN normally from current assoc, since
> it has been updated before sctp_make_shutdown().
Good catch, didn't notice this one.
Will do it. Thanks.

>
> >
> > v1->v2:
> >  - see Patch 3/3.
> >
> > Xin Long (3):
> >  sctp: do asoc update earlier in sctp_sf_do_dupcook_a
> >  Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK"
> >  sctp: do asoc update earlier in sctp_sf_do_dupcook_b
> >
> > include/net/sctp/command.h |  1 -
> > net/sctp/sm_sideeffect.c   | 26 ------------------------
> > net/sctp/sm_statefuns.c    | 50 ++++++++++++++++++++++++++++++++++++----------
> > 3 files changed, 39 insertions(+), 38 deletions(-)
> >
> > --
> > 2.1.0

      reply	other threads:[~2021-05-01 18:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-30 20:02 Xin Long
2021-04-30 20:02 ` [PATCHv2 net 1/3] sctp: do asoc update earlier in sctp_sf_do_dupcook_a Xin Long
2021-04-30 20:02   ` [PATCHv2 net 2/3] Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK" Xin Long
2021-04-30 20:03     ` [PATCHv2 net 3/3] sctp: do asoc update earlier in sctp_sf_do_dupcook_b Xin Long
2021-05-01 16:57       ` Leppanen, Jere (Nokia - FI/Espoo)
2021-05-01 18:20         ` Xin Long
2021-05-01 16:56     ` [PATCHv2 net 2/3] Revert "sctp: Fix bundling of SHUTDOWN with COOKIE-ACK" Leppanen, Jere (Nokia - FI/Espoo)
2021-04-30 22:30 ` [PATCHv2 net 0/3] sctp: always send a chunk with the asoc that it belongs to patchwork-bot+netdevbpf
2021-05-01 16:53 ` Leppanen, Jere (Nokia - FI/Espoo)
2021-05-01 18:22   ` Xin Long [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADvbK_eBGFU1dGX+T73HidNT44KZR_Cqd=16YjUfKwcS7AK4sQ@mail.gmail.com' \
    --to=lucien.xin@gmail.com \
    --cc=alexander.sverdlin@nokia.com \
    --cc=davem@davemloft.net \
    --cc=jere.leppanen@nokia.com \
    --cc=kuba@kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --subject='Re: [PATCHv2 net 0/3] sctp: always send a chunk with the asoc that it belongs to' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).