From: Xin Long <lucien.xin@gmail.com>
To: linux-sctp@vger.kernel.org
Subject: Re: sctp discarding received data chunks
Date: Sat, 10 Oct 2020 02:35:22 +0000 [thread overview]
Message-ID: <CADvbK_farVU-bB9NeLSDfmCgPcdG2Oe44-odeU0o+b2BwfRA0g@mail.gmail.com> (raw)
In-Reply-To: <e377e7e2a87e4f078e7a6d82992cfda0@AcuMS.aculab.com>
On Fri, Oct 9, 2020 at 9:03 PM David Laight <David.Laight@aculab.com> wrote:
>
> From: David Laight
> > Sent: 09 October 2020 12:14
> >
> > From: Andreas Fink
> > > Sent: 09 October 2020 08:25
> > >
> > > Can you see this issue with the 5.4 kernel too?
> > >
> > > I did yesterday some testing by upgrading kernel from 5.4 to 5.7 and I run into all sorts of links
> > > going off after a while so I had to revert back.
> > > 5.4 is stable for me. 5.7 is not. And I have lots of M2PA and M3UA connections like you
> >
> > I've just spent hours digging through my traces.
> > It is only some messages through the connection that get lost!
> >
> > Now SCTP_MIN_IN_DATA_CHUNK_DISCARDS is only incremented in two
> > adjacent places in sm_statefuncs.c.
> >
> > Either for bad TSN (unlikely when everything is using "lo")
> > and bad STREAM.
> > I suspect it is the 'bad stream' case.
> > I've not double-checked but I bet the discarded packets
> > all have a large stream number.
> ...
>
> If I dump out /proc/net/sctp/assocs and look way over to the right
> (on the next monitor but 1) there are two columns INS and OUTS.
> I've just realised that these are the number of streams.
> Now all my connections are loopback - so I see both sockets for each.
> So I'd expect the INS to match the OUTS of the peer.
> This isn't true.
> When the value should be negotiated down the OUTS value is unchanged.
> So the kernel is sending packets with illegal stream numbers.
> These are acked and then silently discarded.
did it do addstream reconfig or receive any duplicate COOKIE-ECHO in your case?
WARNING: multiple messages have this Message-ID (diff)
From: Xin Long <lucien.xin@gmail.com>
To: David Laight <David.Laight@aculab.com>
Cc: Andreas Fink <afink@list.fink.org>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>
Subject: Re: sctp discarding received data chunks
Date: Sat, 10 Oct 2020 10:35:22 +0800 [thread overview]
Message-ID: <CADvbK_farVU-bB9NeLSDfmCgPcdG2Oe44-odeU0o+b2BwfRA0g@mail.gmail.com> (raw)
Message-ID: <20201010023522.7tCog6dkomV5qhj3_zF0ny_VccQ3EFHJso0EEyKVSVc@z> (raw)
In-Reply-To: <766ffacb7d4c48df81aea64204ff37d9@AcuMS.aculab.com>
On Fri, Oct 9, 2020 at 9:03 PM David Laight <David.Laight@aculab.com> wrote:
>
> From: David Laight
> > Sent: 09 October 2020 12:14
> >
> > From: Andreas Fink
> > > Sent: 09 October 2020 08:25
> > >
> > > Can you see this issue with the 5.4 kernel too?
> > >
> > > I did yesterday some testing by upgrading kernel from 5.4 to 5.7 and I run into all sorts of links
> > > going off after a while so I had to revert back.
> > > 5.4 is stable for me. 5.7 is not. And I have lots of M2PA and M3UA connections like you
> >
> > I've just spent hours digging through my traces.
> > It is only some messages through the connection that get lost!
> >
> > Now SCTP_MIN_IN_DATA_CHUNK_DISCARDS is only incremented in two
> > adjacent places in sm_statefuncs.c.
> >
> > Either for bad TSN (unlikely when everything is using "lo")
> > and bad STREAM.
> > I suspect it is the 'bad stream' case.
> > I've not double-checked but I bet the discarded packets
> > all have a large stream number.
> ...
>
> If I dump out /proc/net/sctp/assocs and look way over to the right
> (on the next monitor but 1) there are two columns INS and OUTS.
> I've just realised that these are the number of streams.
> Now all my connections are loopback - so I see both sockets for each.
> So I'd expect the INS to match the OUTS of the peer.
> This isn't true.
> When the value should be negotiated down the OUTS value is unchanged.
> So the kernel is sending packets with illegal stream numbers.
> These are acked and then silently discarded.
did it do addstream reconfig or receive any duplicate COOKIE-ECHO in your case?
next prev parent reply other threads:[~2020-10-10 2:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:46 sctp discarding received data chunks David Laight
2020-10-08 21:46 ` David Laight
2020-10-09 7:24 ` Andreas Fink
2020-10-09 7:24 ` Andreas Fink
2020-10-09 7:57 ` David Laight
2020-10-09 7:57 ` David Laight
2020-10-09 11:13 ` David Laight
2020-10-09 11:13 ` David Laight
2020-10-09 13:03 ` David Laight
2020-10-09 13:03 ` David Laight
2020-10-10 2:35 ` Xin Long [this message]
2020-10-10 2:35 ` Xin Long
2020-10-10 15:10 ` David Laight
2020-10-10 15:10 ` David Laight
2020-10-11 8:33 ` Andreas Fink
2020-10-11 8:33 ` Andreas Fink
2020-10-11 15:28 ` David Laight
2020-10-11 15:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADvbK_farVU-bB9NeLSDfmCgPcdG2Oe44-odeU0o+b2BwfRA0g@mail.gmail.com \
--to=lucien.xin@gmail.com \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).