From: Andreas Fink <afink@list.fink.org>
To: linux-sctp@vger.kernel.org
Subject: Re: sctp discarding received data chunks
Date: Sun, 11 Oct 2020 08:33:22 +0000 [thread overview]
Message-ID: <DBE38DD7-A378-4269-A839-4CB0A41D948B@list.fink.org> (raw)
In-Reply-To: <e377e7e2a87e4f078e7a6d82992cfda0@AcuMS.aculab.com>
>
> Extremely unlikely.
>
> Looking at the latest version of my driver code
> (which I wasn't using) I wrote the following:
>
> * Since the code that negotiates the number of streams got broken
> * in version 5.1 we need to extract the correct value from the
> * internal structures to avoid SCTP sending messages the remote
> * system will discard.
>
> /* stream.outcnt is the value we should be using.
> * But kernels 5.1 to 5.8 fail to reduce it based on the number
> * received from the remote system.
> * So bound here so that transmitted messages don't get discarded. */
> outcnt = asoc->stream.outcnt;
> num_ostreams = asoc->c.sinit_num_ostreams;
>
> I think there was a patch done for 5.9.
> It needs back-porting.
>
> Although Andreas said 5.4 worked for him.
> So maybe he has a different problem.
>
In my application code, I never use anything else than stream 0 and 1
So I see some other issue in kernel 5.8 which makes it go haywire.
WARNING: multiple messages have this Message-ID (diff)
From: Andreas Fink <afink@list.fink.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Xin Long <lucien.xin@gmail.com>,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>
Subject: Re: sctp discarding received data chunks
Date: Sun, 11 Oct 2020 10:33:22 +0200 [thread overview]
Message-ID: <DBE38DD7-A378-4269-A839-4CB0A41D948B@list.fink.org> (raw)
Message-ID: <20201011083322.BLs2RGO67vf5PgsEdr9K4OfJjh96vzhRnfOaX-cctB8@z> (raw)
In-Reply-To: <5af24669b72c4bbb9456b53c397489a4@AcuMS.aculab.com>
>
> Extremely unlikely.
>
> Looking at the latest version of my driver code
> (which I wasn't using) I wrote the following:
>
> * Since the code that negotiates the number of streams got broken
> * in version 5.1 we need to extract the correct value from the
> * internal structures to avoid SCTP sending messages the remote
> * system will discard.
>
> /* stream.outcnt is the value we should be using.
> * But kernels 5.1 to 5.8 fail to reduce it based on the number
> * received from the remote system.
> * So bound here so that transmitted messages don't get discarded. */
> outcnt = asoc->stream.outcnt;
> num_ostreams = asoc->c.sinit_num_ostreams;
>
> I think there was a patch done for 5.9.
> It needs back-porting.
>
> Although Andreas said 5.4 worked for him.
> So maybe he has a different problem.
>
In my application code, I never use anything else than stream 0 and 1
So I see some other issue in kernel 5.8 which makes it go haywire.
next prev parent reply other threads:[~2020-10-11 8:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-08 21:46 sctp discarding received data chunks David Laight
2020-10-08 21:46 ` David Laight
2020-10-09 7:24 ` Andreas Fink
2020-10-09 7:24 ` Andreas Fink
2020-10-09 7:57 ` David Laight
2020-10-09 7:57 ` David Laight
2020-10-09 11:13 ` David Laight
2020-10-09 11:13 ` David Laight
2020-10-09 13:03 ` David Laight
2020-10-09 13:03 ` David Laight
2020-10-10 2:35 ` Xin Long
2020-10-10 2:35 ` Xin Long
2020-10-10 15:10 ` David Laight
2020-10-10 15:10 ` David Laight
2020-10-11 8:33 ` Andreas Fink [this message]
2020-10-11 8:33 ` Andreas Fink
2020-10-11 15:28 ` David Laight
2020-10-11 15:28 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBE38DD7-A378-4269-A839-4CB0A41D948B@list.fink.org \
--to=afink@list.fink.org \
--cc=linux-sctp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).