linux-sctp.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michael Tuexen <tuexen@fh-muenster.de>
To: Xin Long <lucien.xin@gmail.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	network dev <netdev@vger.kernel.org>,
	linux-sctp@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
	davem <davem@davemloft.net>, Guillaume Nault <gnault@redhat.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Subject: Re: [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks
Date: Thu, 22 Oct 2020 13:38:38 +0200	[thread overview]
Message-ID: <EC95E629-CB0D-463A-99B3-5C474D4DD3F3@fh-muenster.de> (raw)
In-Reply-To: <CADvbK_cZua_+2e=u--cV4jH5tR=24DvcEtwcHfAp1kyq9sYofA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 4183 bytes --]

`On 22. Oct 2020, at 05:12, Xin Long <lucien.xin@gmail.com> wrote:
> 
> On Wed, Oct 21, 2020 at 5:13 PM Michael Tuexen <tuexen@fh-muenster.de> wrote:
>> 
>>> On 21. Oct 2020, at 06:16, Xin Long <lucien.xin@gmail.com> wrote:
>>> 
>>> On Wed, Oct 21, 2020 at 5:23 AM Marcelo Ricardo Leitner
>>> <marcelo.leitner@gmail.com> wrote:
>>>> 
>>>> On Tue, Oct 20, 2020 at 11:15:26PM +0200, Michael Tuexen wrote:
>>>>>> On 20. Oct 2020, at 23:11, Marcelo Ricardo Leitner <marcelo.leitner@gmail.com> wrote:
>>>>>> 
>>>>>> On Tue, Oct 20, 2020 at 05:12:06PM +0800, Xin Long wrote:
>>>>>>> On Tue, Oct 20, 2020 at 6:15 AM Marcelo Ricardo Leitner
>>>>>>> <marcelo.leitner@gmail.com> wrote:
>>>>>>>> 
>>>>>>>> On Mon, Oct 19, 2020 at 08:25:33PM +0800, Xin Long wrote:
>>>>>>>>> --- a/Documentation/networking/ip-sysctl.rst
>>>>>>>>> +++ b/Documentation/networking/ip-sysctl.rst
>>>>>>>>> @@ -2640,6 +2640,12 @@ addr_scope_policy - INTEGER
>>>>>>>>> 
>>>>>>>>>    Default: 1
>>>>>>>>> 
>>>>>>>>> +udp_port - INTEGER
>>>>>>>> 
>>>>>>>> Need to be more verbose here, and also mention the RFC.
>>>>>>>> 
>>>>>>>>> +     The listening port for the local UDP tunneling sock.
>>>>>>>>      , shared by all applications in the same net namespace.
>>>>>>>>> +     UDP encapsulation will be disabled when it's set to 0.
>>>>>>>> 
>>>>>>>>      "Note, however, that setting just this is not enough to actually
>>>>>>>>      use it. ..."
>>>>>>> When it's a client, yes,  but when it's a server, the encap_port can
>>>>>>> be got from the incoming packet.
>>>>>>> 
>>>>>>>> 
>>>>>>>>> +
>>>>>>>>> +     Default: 9899
>>>>>>>>> +
>>>>>>>>> encap_port - INTEGER
>>>>>>>>>    The default remote UDP encapsalution port.
>>>>>>>>>    When UDP tunneling is enabled, this global value is used to set
>>>>>>>> 
>>>>>>>> When is it enabled, which conditions are needed? Maybe it can be
>>>>>>>> explained only in the one above.
>>>>>>> Thanks!
>>>>>>> pls check if this one will be better:
>>>>>> 
>>>>>> It is. Verbose enough now, thx.
>>>>>> (one other comment below)
>>>>>> 
>>>>>>> 
>>>>>>> udp_port - INTEGER
>>>>>>> 
>>>>>>> The listening port for the local UDP tunneling sock.
>>>>>>> 
>>>>>>> This UDP sock is used for processing the incoming UDP-encapsulated
>>>>>>> SCTP packets (from RFC6951), and shared by all applications in the
>>>>>>> same net namespace. This UDP sock will be closed when the value is
>>>>>>> set to 0.
>>>>>>> 
>>>>>>> The value will also be used to set the src port of the UDP header
>>>>>>> for the outgoing UDP-encapsulated SCTP packets. For the dest port,
>>>>>>> please refer to 'encap_port' below.
>>>>>>> 
>>>>>>> Default: 9899
>>>>>> 
>>>>>> I'm now wondering if this is the right default. I mean, it is the
>>>>>> standard port for it, yes, but at the same time, it means loading SCTP
>>>>>> module will steal/use that UDP port on all net namespaces and can lead
>>>>>> to conflicts with other apps. A more conservative approach here is to
>>>>>> document the standard port, but set the default to 0 and require the
>>>>>> user to set it in if it is expected to be used.
>>>>>> 
>>>>>> Did FreeBSD enable it by default too?
>>>>> No. The default is 0, which means that the encapsulation is turned off.
>>>>> Setting this sysctl variable to a non-zero value enables the UDP tunneling
>>>>> with the given port.
>>>> 
>>>> Thanks Michael.
>>>> Xin, then we should change this default value (and update the
>>>> documentation above accordingly, to still have the standard port #
>>>> readily available in there).
>>> OK, I misunderstood the RFC.
>> Does that RFC mandate that the feature is on by default? Can you point me to
>> that text?
> Not really.
> 
> I was thinking that by leaving it to 9899 by default users don't need to
> know the port when want to use it, and yet I didn't want to add another
> sysctl member. :D
OK. Thanks for letting me know.

Best regards
Michael
> 
>> 
>> Best regards
>> Michael
>>> 
>>> I will remove the call to sctp_udp_sock_start/stop() from
>>> sctp_ctrlsock_init/exit(), and set the udp_port as 0 by default.
>>> 
>>> Thanks.
>> 


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5257 bytes --]

  parent reply	other threads:[~2020-10-22 11:38 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 12:25 [PATCHv4 net-next 00/16] sctp: Implement RFC6951: UDP Encapsulation of SCTP Xin Long
2020-10-19 12:25 ` Xin Long
2020-10-19 12:25 ` [PATCHv4 net-next 01/16] udp: check udp sock encap_type in __udp_lib_err Xin Long
2020-10-19 12:25   ` Xin Long
2020-10-19 12:25   ` [PATCHv4 net-next 02/16] udp6: move the mss check after udp gso tunnel processing Xin Long
2020-10-19 12:25     ` Xin Long
2020-10-19 12:25     ` [PATCHv4 net-next 03/16] udp: support sctp over udp in skb_udp_tunnel_segment Xin Long
2020-10-19 12:25       ` Xin Long
2020-10-19 12:25       ` [PATCHv4 net-next 04/16] sctp: create udp4 sock and add its encap_rcv Xin Long
2020-10-19 12:25         ` Xin Long
2020-10-19 12:25         ` [PATCHv4 net-next 05/16] sctp: create udp6 sock and set " Xin Long
2020-10-19 12:25           ` Xin Long
2020-10-19 12:25           ` [PATCHv4 net-next 06/16] sctp: add encap_err_lookup for udp encap socks Xin Long
2020-10-19 12:25             ` Xin Long
2020-10-19 12:25             ` [PATCHv4 net-next 07/16] sctp: add encap_port for netns sock asoc and transport Xin Long
2020-10-19 12:25               ` Xin Long
2020-10-19 12:25               ` [PATCHv4 net-next 08/16] sctp: add SCTP_REMOTE_UDP_ENCAPS_PORT sockopt Xin Long
2020-10-19 12:25                 ` Xin Long
2020-10-19 12:25                 ` [PATCHv4 net-next 09/16] sctp: allow changing transport encap_port by peer packets Xin Long
2020-10-19 12:25                   ` Xin Long
2020-10-19 12:25                   ` [PATCHv4 net-next 10/16] sctp: add udphdr to overhead when udp_port is set Xin Long
2020-10-19 12:25                     ` Xin Long
2020-10-19 12:25                     ` [PATCHv4 net-next 11/16] sctp: call sk_setup_caps in sctp_packet_transmit instead Xin Long
2020-10-19 12:25                       ` Xin Long
2020-10-19 12:25                       ` [PATCHv4 net-next 12/16] sctp: support for sending packet over udp4 sock Xin Long
2020-10-19 12:25                         ` Xin Long
2020-10-19 12:25                         ` [PATCHv4 net-next 13/16] sctp: support for sending packet over udp6 sock Xin Long
2020-10-19 12:25                           ` Xin Long
2020-10-19 12:25                           ` [PATCHv4 net-next 14/16] sctp: add the error cause for new encapsulation port restart Xin Long
2020-10-19 12:25                             ` Xin Long
2020-10-19 12:25                             ` [PATCHv4 net-next 15/16] sctp: handle the init chunk matching an existing asoc Xin Long
2020-10-19 12:25                               ` Xin Long
2020-10-19 12:25                               ` [PATCHv4 net-next 16/16] sctp: enable udp tunneling socks Xin Long
2020-10-19 12:25                                 ` Xin Long
2020-10-19 22:15                                 ` Marcelo Ricardo Leitner
2020-10-19 22:15                                   ` Marcelo Ricardo Leitner
2020-10-19 22:29                                   ` Marcelo Ricardo Leitner
2020-10-19 22:29                                     ` Marcelo Ricardo Leitner
2020-10-20  9:12                                   ` Xin Long
2020-10-20  9:12                                     ` Xin Long
2020-10-20 21:11                                     ` Marcelo Ricardo Leitner
2020-10-20 21:11                                       ` Marcelo Ricardo Leitner
2020-10-20 21:15                                       ` Michael Tuexen
2020-10-20 21:15                                         ` Michael Tuexen
2020-10-20 21:23                                         ` Marcelo Ricardo Leitner
2020-10-20 21:23                                           ` Marcelo Ricardo Leitner
2020-10-20 22:08                                           ` David Laight
2020-10-20 22:13                                             ` 'Marcelo Ricardo Leitner'
2020-10-20 22:13                                               ` 'Marcelo Ricardo Leitner'
2020-10-21  4:16                                           ` Xin Long
2020-10-21  9:13                                             ` Michael Tuexen
2020-10-22  3:12                                               ` Xin Long
2020-10-22  8:47                                                 ` David Laight
2020-10-26  5:58                                                   ` Xin Long
2020-10-22 11:38                                                 ` Michael Tuexen [this message]
2020-10-19 22:14               ` [PATCHv4 net-next 07/16] sctp: add encap_port for netns sock asoc and transport Marcelo Ricardo Leitner
2020-10-19 22:14                 ` Marcelo Ricardo Leitner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=EC95E629-CB0D-463A-99B3-5C474D4DD3F3@fh-muenster.de \
    --to=tuexen@fh-muenster.de \
    --cc=davem@davemloft.net \
    --cc=gnault@redhat.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=pabeni@redhat.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).