From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
davem@davemloft.net, kuba@kernel.org, linux-sctp@vger.kernel.org,
Jacek Szafraniec <jacek.szafraniec@nokia.com>
Subject: Re: [PATCH net] sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set
Date: Wed, 21 Jul 2021 15:42:27 -0300 [thread overview]
Message-ID: <YPhqk1Sx5FKYyiK+@horizon.localdomain> (raw)
In-Reply-To: <a0a956bbb2142d8de933d20a7a01e8ce66d048c0.1626883705.git.lucien.xin@gmail.com>
On Wed, Jul 21, 2021 at 12:08:25PM -0400, Xin Long wrote:
> Currently, in sctp_packet_config(), sctp_transport_pmtu_check() is
> called to update transport pathmtu with dst's mtu when dst's mtu
> has been changed by non sctp stack like xfrm.
>
> However, this should only happen when SPP_PMTUD_ENABLE is set, no
> matter where dst's mtu changed. This patch is to fix by checking
> SPP_PMTUD_ENABLE flag before calling sctp_transport_pmtu_check().
>
> Thanks Jacek for reporting and looking into this issue.
>
> Fixes: 69fec325a643 ('Revert "sctp: remove sctp_transport_pmtu_check"')
> Reported-by: Jacek Szafraniec <jacek.szafraniec@nokia.com>
> Tested-by: Jacek Szafraniec <jacek.szafraniec@nokia.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/output.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/sctp/output.c b/net/sctp/output.c
> index 9032ce60d50e..8d5708dd2a1f 100644
> --- a/net/sctp/output.c
> +++ b/net/sctp/output.c
> @@ -104,8 +104,8 @@ void sctp_packet_config(struct sctp_packet *packet, __u32 vtag,
> if (asoc->param_flags & SPP_PMTUD_ENABLE)
> sctp_assoc_sync_pmtu(asoc);
> } else if (!sctp_transport_pl_enabled(tp) &&
> - !sctp_transport_pmtu_check(tp)) {
> - if (asoc->param_flags & SPP_PMTUD_ENABLE)
> + asoc->param_flags & SPP_PMTUD_ENABLE)
Lacks a '{' here at the end of the line.
Other than that:
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
(please add it on the v2)
> + if (!sctp_transport_pmtu_check(tp))
> sctp_assoc_sync_pmtu(asoc);
> }
>
> --
> 2.27.0
>
next prev parent reply other threads:[~2021-07-21 18:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 16:08 [PATCH net] sctp: do not update transport pathmtu if SPP_PMTUD_ENABLE is not set Xin Long
2021-07-21 18:42 ` Marcelo Ricardo Leitner [this message]
2021-07-21 18:49 ` Xin Long
2021-07-21 19:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPhqk1Sx5FKYyiK+@horizon.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=jacek.szafraniec@nokia.com \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).