From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05513C433EF for ; Thu, 17 Feb 2022 09:40:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238749AbiBQJku (ORCPT ); Thu, 17 Feb 2022 04:40:50 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:44928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232999AbiBQJkt (ORCPT ); Thu, 17 Feb 2022 04:40:49 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59EE929720E for ; Thu, 17 Feb 2022 01:40:35 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1AA101F383; Thu, 17 Feb 2022 09:40:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1645090834; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=par63/FR9F0L/1vSXTdbL1MRNNPz8a9EIJtPr6UY9Uk=; b=ncyUkO91Rs67B0LBV5Gvx95/zepy8nugj+noLwhWZkF2mRz6yp9/LKeJgAs//KMP5NsElg mgnI/pYHvzj3dkCtBAQOjyu0E9tqBCCQ1r1W/dRO7KmEAj2ahfTAVFcD53DZZk7WrNqVhH sMMXC9/mtlu3kc/yXmJZT5eU8IwLnKo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1645090834; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=par63/FR9F0L/1vSXTdbL1MRNNPz8a9EIJtPr6UY9Uk=; b=8OSwOG8kcvVRVT6eIKDH9IGg5QqyMc3pjG6kJBYHsmYC5+fjMmnqbYEwOIKxgyF9gRmEfU QgDjW2QY7wx7iQBA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 066FD13BBF; Thu, 17 Feb 2022 09:40:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EWBGABIYDmKiKAAAMHmgww (envelope-from ); Thu, 17 Feb 2022 09:40:34 +0000 Date: Thu, 17 Feb 2022 10:42:41 +0100 From: Cyril Hrubis To: Petr Vorel Cc: ltp@lists.linux.it, Marcelo Ricardo Leitner , Neil Horman , Vlad Yasevich , linux-sctp@vger.kernel.org Subject: Re: [PATCH 1/2] sctputil.h: Fix some formatting Message-ID: References: <20220203170522.22051-1-pvorel@suse.cz> <20220203170522.22051-2-pvorel@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220203170522.22051-2-pvorel@suse.cz> Precedence: bulk List-ID: X-Mailing-List: linux-sctp@vger.kernel.org Hi! > static inline void *test_malloc(size_t size) > { > void *buf = malloc(size); > - if (NULL == buf) > - tst_brkm(TBROK, tst_exit, "malloc failed"); > + > + if (NULL == buf) > + tst_brkm(TBROK, tst_exit, "malloc failed"); This one has still constant on the right and I would rather change this to the more common if (!buf) variant as well. Other than that it's pretty obviously fine: Reviewed-by: Cyril Hrubis > return buf; > } > > -- > 2.35.1 > -- Cyril Hrubis chrubis@suse.cz