From: Cyril Hrubis <chrubis@suse.cz>
To: Petr Vorel <pvorel@suse.cz>
Cc: ltp@lists.linux.it,
Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>,
linux-sctp@vger.kernel.org
Subject: Re: [PATCH 2/2] sctputil.h: TCONF on EAFNOSUPPORT
Date: Thu, 17 Feb 2022 10:56:07 +0100 [thread overview]
Message-ID: <Yg4bt2V6rrircZ+x@yuki> (raw)
In-Reply-To: <20220203170522.22051-3-pvorel@suse.cz>
Hi!
> diff --git a/utils/sctp/testlib/sctputil.h b/utils/sctp/testlib/sctputil.h
> index 1e21760bec..c4bedb47cf 100644
> --- a/utils/sctp/testlib/sctputil.h
> +++ b/utils/sctp/testlib/sctputil.h
> @@ -133,9 +133,14 @@ extern int TST_CNT;
> static inline int test_socket(int domain, int type, int protocol)
> {
> int sk = socket(domain, type, protocol);
> + int res = TBROK;
>
> - if (sk == -1)
> - tst_brkm(TBROK, tst_exit, "socket: %s", strerror(errno));
> + if (sk == -1) {
> + if (errno == EAFNOSUPPORT)
> + res = TCONF;
> +
> + tst_brkm(res, tst_exit, "socket: %s", strerror(errno));
> + }
I would keep the messages separated here, i.e. do something as:
if (errno == EAFNOSUPPORT)
tst_brkm(TBROK | TERRNO, "socket(%i, %i, %i) not supported",
domain, type, protocol);
tst_brkm(TBROK | TERRNO, "socket()");
Btw this code actually duplicates the safe_socket() function we do have
already, so it may as well be easier to just replace the test_socket()
with SAFE_SOCKET() in the tests...
--
Cyril Hrubis
chrubis@suse.cz
next prev parent reply other threads:[~2022-02-17 9:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-03 17:05 [PATCH 0/2] Fix SCTP tests on systems with disabled IPv6 Petr Vorel
2022-02-03 17:05 ` [PATCH 1/2] sctputil.h: Fix some formatting Petr Vorel
2022-02-17 9:42 ` Cyril Hrubis
2022-02-17 9:45 ` Cyril Hrubis
2022-02-03 17:05 ` [PATCH 2/2] sctputil.h: TCONF on EAFNOSUPPORT Petr Vorel
2022-02-17 9:56 ` Cyril Hrubis [this message]
2022-02-17 11:45 ` Petr Vorel
2022-02-17 12:18 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yg4bt2V6rrircZ+x@yuki \
--to=chrubis@suse.cz \
--cc=linux-sctp@vger.kernel.org \
--cc=ltp@lists.linux.it \
--cc=marcelo.leitner@gmail.com \
--cc=nhorman@tuxdriver.com \
--cc=pvorel@suse.cz \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).