From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Petr Malat <oss@malat.biz>,
linux-sctp@vger.kernel.org, Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH] sctp: Initialize daddr on peeled off socket
Date: Fri, 8 Apr 2022 14:18:17 -0300 [thread overview]
Message-ID: <YlBuWfEg/njGjSkt@t14s.localdomain> (raw)
In-Reply-To: <20220408093342.022431f7@kernel.org>
On Fri, Apr 08, 2022 at 09:33:42AM -0700, Jakub Kicinski wrote:
> On Fri, 8 Apr 2022 14:35:22 +0200 Petr Malat wrote:
> > On Mon, Mar 07, 2022 at 01:33:21PM -0800, Jakub Kicinski wrote:
> > > On Mon, 7 Mar 2022 20:59:29 +0100 Petr Malat wrote:
> > > > Function sctp_do_peeloff() wrongly initializes daddr of the original
> > > > socket instead of the peeled off one, which makes getpeername() return
> > > > zeroes instead of the primary address. Initialize the new socket
> > > > instead.
> > >
> > > Could you add a Fixes tag?
> >
> > Hi Jakub,
> > have you got some time to review the updated version with "Fixes" tag
> > added?
>
> Thanks for adding the tag. Long story short if you got no replies from
> SCTP folks on the posting to linux-sctp@ repost with netdev@ added.
> That way it'll get into general networking patchwork / patch processing
> queue.
Yup. Also, the patch itself always need to be posted to netdev@
anyway, because we can't take patches directly from linux-sctp@. Well,
unless you mean to not officially submit the patch at a given time for
some reason, that is.
>
> > The issue has been in the kernel for a while, because my app is using
> > peer addresses for storing sockets in a hash table and the hash table can
> > handle collisions, thus I haven't noticed it's broken until I dumped
> > the hash table while working on another problem.
prev parent reply other threads:[~2022-04-08 17:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-07 19:59 [PATCH] sctp: Initialize daddr on peeled off socket Petr Malat
2022-03-07 21:33 ` Jakub Kicinski
2022-03-07 22:02 ` [PATCH v2] " Petr Malat
2022-04-08 17:34 ` Marcelo Ricardo Leitner
2022-04-09 6:36 ` [PATCH] " Petr Malat
2022-04-12 3:40 ` patchwork-bot+netdevbpf
2022-04-08 12:35 ` Petr Malat
2022-04-08 16:33 ` Jakub Kicinski
2022-04-08 17:18 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YlBuWfEg/njGjSkt@t14s.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=oss@malat.biz \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).