From: David Laight <David.Laight@ACULAB.COM>
To: 'Marcelo Ricardo Leitner' <marcelo.leitner@gmail.com>,
Christoph Hellwig <hch@lst.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
"linux-sctp@vger.kernel.org" <linux-sctp@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cluster-devel@redhat.com" <cluster-devel@redhat.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH 2/4] sctp: refactor sctp_setsockopt_bindx
Date: Mon, 01 Jun 2020 08:27:08 +0000 [thread overview]
Message-ID: <ef0754831c294934b67f89fd8c5e1b5b@AcuMS.aculab.com> (raw)
In-Reply-To: <20200529160544.GI2491@localhost.localdomain>
From: Marcelo Ricardo Leitner
> Sent: 29 May 2020 17:06
> On Fri, May 29, 2020 at 02:09:41PM +0200, Christoph Hellwig wrote:
> > Split out a sctp_setsockopt_bindx_kernel that takes a kernel pointer
> > to the sockaddr and make sctp_setsockopt_bindx a small wrapper around
> > it. This prepares for adding a new bind_add proto op.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
>
> > ---
> > net/sctp/socket.c | 61 ++++++++++++++++++++++-------------------------
> > 1 file changed, 28 insertions(+), 33 deletions(-)
> >
> > diff --git a/net/sctp/socket.c b/net/sctp/socket.c
> > index 827a9903ee288..6e745ac3c4a59 100644
> > --- a/net/sctp/socket.c
> > +++ b/net/sctp/socket.c
> > @@ -972,23 +972,22 @@ int sctp_asconf_mgmt(struct sctp_sock *sp, struct sctp_sockaddr_entry *addrw)
> > * it.
> > *
> > * sk The sk of the socket
> > - * addrs The pointer to the addresses in user land
> > + * addrs The pointer to the addresses
> > * addrssize Size of the addrs buffer
> > * op Operation to perform (add or remove, see the flags of
> > * sctp_bindx)
> > *
> > * Returns 0 if ok, <0 errno code on error.
> > */
> > -static int sctp_setsockopt_bindx(struct sock *sk,
> > - struct sockaddr __user *addrs,
> > - int addrs_size, int op)
> > +static int sctp_setsockopt_bindx_kernel(struct sock *sk,
const
> > + struct sockaddr *addrs, int addrs_size,
> > + int op)
The list of addresses ought to be 'const'.
IIRC that requires the test for 'port = 0' be moved down a few layers.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2020-06-01 8:27 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-29 12:09 remove kernel_setsockopt v4 Christoph Hellwig
2020-05-29 12:09 ` [PATCH 1/4] sctp: add sctp_sock_set_nodelay Christoph Hellwig
2020-05-29 16:05 ` Marcelo Ricardo Leitner
2020-05-29 18:09 ` David Teigland
2020-05-29 12:09 ` [PATCH 2/4] sctp: refactor sctp_setsockopt_bindx Christoph Hellwig
2020-05-29 16:05 ` Marcelo Ricardo Leitner
2020-06-01 8:27 ` David Laight [this message]
2020-05-29 12:09 ` [PATCH 3/4] net: add a new bind_add method Christoph Hellwig
2020-05-29 16:06 ` Marcelo Ricardo Leitner
2020-05-29 12:09 ` [PATCH 4/4] net: remove kernel_setsockopt Christoph Hellwig
2020-05-29 12:27 ` David Laight
2020-05-29 12:29 ` 'Christoph Hellwig'
2020-05-29 16:10 ` Marcelo Ricardo Leitner
2020-05-29 20:11 ` remove kernel_setsockopt v4 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef0754831c294934b67f89fd8c5e1b5b@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=cluster-devel@redhat.com \
--cc=davem@davemloft.net \
--cc=hch@lst.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).