From: Waiman Long <longman@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, netdev@vger.kernel.org,
linux-afs@lists.infradead.org, Sumit Garg <sumit.garg@linaro.org>,
Jerry Snitselaar <jsnitsel@redhat.com>,
Roberto Sassu <roberto.sassu@huawei.com>,
Eric Biggers <ebiggers@google.com>,
Chris von Recklinghausen <crecklin@redhat.com>
Subject: Re: [PATCH v7 2/2] KEYS: Avoid false positive ENOMEM error on key read
Date: Sat, 21 Mar 2020 20:46:33 -0400 [thread overview]
Message-ID: <03c0c59e-a84b-bd75-6b3f-7f6467d806e2@redhat.com> (raw)
In-Reply-To: <e3d7a227-8915-5c00-cd34-fe2db7fc7121@I-love.SAKURA.ne.jp>
On 3/21/20 8:31 PM, Tetsuo Handa wrote:
> On 2020/03/22 3:49, Waiman Long wrote:
>> + do {
>> + if (ret > key_data_len) {
>> + if (unlikely(key_data))
>> + __kvzfree(key_data, key_data_len);
>> + key_data_len = ret;
>> + continue; /* Allocate buffer */
> Excuse me, but "continue;" inside "do { ... } while (0);" means "break;"
> because "while (0)" is evaluated before continuing the loop.
You are right. My mistake. Will send out a new one for patch 2.
-Longman
prev parent reply other threads:[~2020-03-22 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-21 18:49 [PATCH v7 0/2] KEYS: Read keys to internal buffer & then copy to userspace Waiman Long
2020-03-21 18:49 ` [PATCH v7 1/2] KEYS: Don't write out to userspace while holding key semaphore Waiman Long
2020-03-21 18:49 ` [PATCH v7 2/2] KEYS: Avoid false positive ENOMEM error on key read Waiman Long
2020-03-22 0:31 ` Tetsuo Handa
2020-03-22 0:46 ` Waiman Long [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03c0c59e-a84b-bd75-6b3f-7f6467d806e2@redhat.com \
--to=longman@redhat.com \
--cc=crecklin@redhat.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=ebiggers@google.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jmorris@namei.org \
--cc=jsnitsel@redhat.com \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=roberto.sassu@huawei.com \
--cc=serge@hallyn.com \
--cc=sumit.garg@linaro.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).