From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B38BC4332D for ; Sun, 22 Mar 2020 00:46:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 401A4206F9 for ; Sun, 22 Mar 2020 00:46:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DUEc+2Ac" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728184AbgCVAqm (ORCPT ); Sat, 21 Mar 2020 20:46:42 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:60714 "EHLO us-smtp-delivery-74.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728178AbgCVAqm (ORCPT ); Sat, 21 Mar 2020 20:46:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584838001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qXvBGWf4H3tlxTPY3JL9NJZyGrJzCSjYj7K4kPcMwd8=; b=DUEc+2AcFtpsq1dBDy1Qj43GMiYVECQ2ICJc/M3Rdu16Lh3xfdiW7l0Uq1/z3lg6SXiHZK btQ09veZtOTEIb58YabxM8kIli+4lgDaZrcVbdKVdG6R//txSGJh+4X0MCM6ICh3DWyP2g QO+OtBhn9x83MVrQnH0JHarnOlASxHg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-359-I8Rx9gchNNiov0sHixcL3w-1; Sat, 21 Mar 2020 20:46:39 -0400 X-MC-Unique: I8Rx9gchNNiov0sHixcL3w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 32D37100550E; Sun, 22 Mar 2020 00:46:36 +0000 (UTC) Received: from llong.remote.csb (ovpn-112-193.rdu2.redhat.com [10.10.112.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 79FD91000325; Sun, 22 Mar 2020 00:46:33 +0000 (UTC) Subject: Re: [PATCH v7 2/2] KEYS: Avoid false positive ENOMEM error on key read To: Tetsuo Handa Cc: David Howells , Jarkko Sakkinen , James Morris , "Serge E. Hallyn" , Mimi Zohar , "David S. Miller" , Jakub Kicinski , keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, Sumit Garg , Jerry Snitselaar , Roberto Sassu , Eric Biggers , Chris von Recklinghausen References: <20200321184932.16579-1-longman@redhat.com> <20200321184932.16579-3-longman@redhat.com> From: Waiman Long Organization: Red Hat Message-ID: <03c0c59e-a84b-bd75-6b3f-7f6467d806e2@redhat.com> Date: Sat, 21 Mar 2020 20:46:33 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On 3/21/20 8:31 PM, Tetsuo Handa wrote: > On 2020/03/22 3:49, Waiman Long wrote: >> + do { >> + if (ret > key_data_len) { >> + if (unlikely(key_data)) >> + __kvzfree(key_data, key_data_len); >> + key_data_len = ret; >> + continue; /* Allocate buffer */ > Excuse me, but "continue;" inside "do { ... } while (0);" means "break;" > because "while (0)" is evaluated before continuing the loop. You are right. My mistake. Will send out a new one for patch 2. -Longman