Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] x86/efi: remove unused variables
@ 2019-11-15 13:08 YueHaibing
  2019-11-29 12:05 ` Michael Ellerman
  2019-12-02 14:38 ` Nayna
  0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2019-11-15 13:08 UTC (permalink / raw)
  To: jmorris, serge, nayna, zohar, dhowells, jwboyer, yuehaibing
  Cc: linux-security-module, linux-kernel

commit ad723674d675 ("x86/efi: move common keyring
handler functions to new file") leave this unused.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 security/integrity/platform_certs/load_uefi.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
index 4369204..111898a 100644
--- a/security/integrity/platform_certs/load_uefi.c
+++ b/security/integrity/platform_certs/load_uefi.c
@@ -11,11 +11,6 @@
 #include "../integrity.h"
 #include "keyring_handler.h"
 
-static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
-static efi_guid_t efi_cert_x509_sha256_guid __initdata =
-	EFI_CERT_X509_SHA256_GUID;
-static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
-
 /*
  * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
  * it does.
-- 
2.7.4



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] x86/efi: remove unused variables
  2019-11-15 13:08 [PATCH -next] x86/efi: remove unused variables YueHaibing
@ 2019-11-29 12:05 ` Michael Ellerman
  2019-12-02 14:38 ` Nayna
  1 sibling, 0 replies; 3+ messages in thread
From: Michael Ellerman @ 2019-11-29 12:05 UTC (permalink / raw)
  To: YueHaibing, jmorris, serge, nayna, zohar, dhowells, jwboyer, yuehaibing
  Cc: linux-security-module, linux-kernel

YueHaibing <yuehaibing@huawei.com> writes:
> commit ad723674d675 ("x86/efi: move common keyring
> handler functions to new file") leave this unused.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  security/integrity/platform_certs/load_uefi.c | 5 -----
>  1 file changed, 5 deletions(-)

Thanks for spotting this, my x86 test builds did trigger it, but I
didn't notice the new warnings.

I've picked this up into the powerpc tree, as that's where the offending
commit is.

cheers

> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index 4369204..111898a 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -11,11 +11,6 @@
>  #include "../integrity.h"
>  #include "keyring_handler.h"
>  
> -static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
> -static efi_guid_t efi_cert_x509_sha256_guid __initdata =
> -	EFI_CERT_X509_SHA256_GUID;
> -static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
> -
>  /*
>   * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
>   * it does.
> -- 
> 2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] x86/efi: remove unused variables
  2019-11-15 13:08 [PATCH -next] x86/efi: remove unused variables YueHaibing
  2019-11-29 12:05 ` Michael Ellerman
@ 2019-12-02 14:38 ` Nayna
  1 sibling, 0 replies; 3+ messages in thread
From: Nayna @ 2019-12-02 14:38 UTC (permalink / raw)
  To: YueHaibing, jmorris, serge, nayna, zohar, dhowells, jwboyer
  Cc: linux-security-module, linux-kernel


On 11/15/19 8:08 AM, YueHaibing wrote:
> commit ad723674d675 ("x86/efi: move common keyring
> handler functions to new file") leave this unused.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>   security/integrity/platform_certs/load_uefi.c | 5 -----
>   1 file changed, 5 deletions(-)
>
> diff --git a/security/integrity/platform_certs/load_uefi.c b/security/integrity/platform_certs/load_uefi.c
> index 4369204..111898a 100644
> --- a/security/integrity/platform_certs/load_uefi.c
> +++ b/security/integrity/platform_certs/load_uefi.c
> @@ -11,11 +11,6 @@
>   #include "../integrity.h"
>   #include "keyring_handler.h"
>   
> -static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID;
> -static efi_guid_t efi_cert_x509_sha256_guid __initdata =
> -	EFI_CERT_X509_SHA256_GUID;
> -static efi_guid_t efi_cert_sha256_guid __initdata = EFI_CERT_SHA256_GUID;
> -
>   /*
>    * Look to see if a UEFI variable called MokIgnoreDB exists and return true if
>    * it does.


Thanks for noticing and fixing this.

Thanks & Regards,

      - Nayna


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-15 13:08 [PATCH -next] x86/efi: remove unused variables YueHaibing
2019-11-29 12:05 ` Michael Ellerman
2019-12-02 14:38 ` Nayna

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git