Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH -next] security: smack: add watch_queue.h header to fix build errors
@ 2019-10-10 15:24 Randy Dunlap
  2019-10-11  7:54 ` David Howells
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2019-10-10 15:24 UTC (permalink / raw)
  To: linux-security-module, LKML; +Cc: David Howells, Casey Schaufler

From: Randy Dunlap <rdunlap@infradead.org>

Fix build errors when CONFIG_WATCH_QUEUE=y by adding the
appropriate header file.

../security/smack/smack_lsm.c: In function ‘smack_post_notification’:
../security/smack/smack_lsm.c:4384:7: error: dereferencing pointer to incomplete type ‘struct watch_notification’
  if (n->type == WATCH_TYPE_META)
       ^~
../security/smack/smack_lsm.c:4384:17: error: ‘WATCH_TYPE_META’ undeclared (first use in this function); did you mean ‘TCA_PIE_BETA’?
  if (n->type == WATCH_TYPE_META)
                 ^~~~~~~~~~~~~~~
                 TCA_PIE_BETA

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Casey Schaufler <casey@schaufler-ca.com>
Cc: David Howells <dhowells@redhat.com>
Cc: linux-security-module@vger.kernel.org
---
 security/smack/smack_lsm.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-next-20191010.orig/security/smack/smack_lsm.c
+++ linux-next-20191010/security/smack/smack_lsm.c
@@ -42,6 +42,7 @@
 #include <linux/parser.h>
 #include <linux/fs_context.h>
 #include <linux/fs_parser.h>
+#include <linux/watch_queue.h>
 #include "smack.h"
 
 #define TRANS_TRUE	"TRUE"


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -next] security: smack: add watch_queue.h header to fix build errors
  2019-10-10 15:24 [PATCH -next] security: smack: add watch_queue.h header to fix build errors Randy Dunlap
@ 2019-10-11  7:54 ` David Howells
  0 siblings, 0 replies; 2+ messages in thread
From: David Howells @ 2019-10-11  7:54 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: dhowells, linux-security-module, LKML, Casey Schaufler

I've folded in this patch.

David

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-10 15:24 [PATCH -next] security: smack: add watch_queue.h header to fix build errors Randy Dunlap
2019-10-11  7:54 ` David Howells

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git