Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: prakhar srivastava <prsriva02@gmail.com>,
	linux-integrity <linux-integrity@vger.kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: Re: [PATCH 2/3] IMA:Define a new template field buf
Date: Wed, 19 Jun 2019 14:37:06 -0400
Message-ID: <1560969426.3975.64.camel@linux.ibm.com> (raw)
In-Reply-To: <CAEFn8qK9Tg99PA_=Ukm=CwSE6ajjUL2FxLs0ZiVdGLvG_baK_A@mail.gmail.com>

On Wed, 2019-06-19 at 11:08 -0700, prakhar srivastava wrote:
> <snip>
> > >       if (iint->measured_pcrs & (0x1 << pcr))
> > > diff --git a/security/integrity/ima/ima_init.c b/security/integrity/ima/ima_init.c
> > > index 993d0f1915ff..c8591406c0e2 100644
> > > --- a/security/integrity/ima/ima_init.c
> > > +++ b/security/integrity/ima/ima_init.c
> > > @@ -50,7 +50,7 @@ static int __init ima_add_boot_aggregate(void)
> > >       struct ima_template_entry *entry;
> > >       struct integrity_iint_cache tmp_iint, *iint = &tmp_iint;
> > >       struct ima_event_data event_data = {iint, NULL, boot_aggregate_name,
> > > -                                         NULL, 0, NULL};
> > > +                                         NULL, 0, NULL, NULL, 0};
> > >       int result = -ENOMEM;
> > >       int violation = 0;
> > >       struct {
> > >
> >
> > These changes shouldn't be necessary.  Please rebase these patches on
> > top of the latest next-queued-testing branch (git remote update).  "IMA: support for per
> > policy rule template formats" is still changing.
> >
> > Minor nit.  When re-posting the patches please update the patch titles
> > so that there is a space between the subsystem name and the patch
> > title (eg. "ima: define ...").
> >
> I believe the above event_data changes are needed, to store/read the
> buffer length and buffer itself. The only exception will be if needed will be to
> remove ima-buf as a template instead used a template_fmt in the policy
> with KEXEC_CMDLINE from the "IMA: support for per
>  policy rule template formats" is still changing.".
> In my view even ima-buf is needed as it simplifies the usage.
> 
> Please let me know if I misunderstood your comment.

The tip of next-queued-testing branch is commit 687d57f90461 ("IMA:
support for per policy rule template formats").  The current code is:

        struct ima_event_data event_data = { .iint = iint,
                                             .filename = boot_aggregate_name };

Mimi


  reply index

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-17 18:35 [PATCH V8 0/3] Add support for measuring the boot command line during kexec_file_load Prakhar Srivastava
2019-06-17 18:35 ` [PATCH 1/3] IMA:Define a new hook to measure the kexec boot command line arguments Prakhar Srivastava
2019-06-19 19:21   ` Mimi Zohar
2019-06-17 18:35 ` [PATCH 2/3] IMA:Define a new template field buf Prakhar Srivastava
2019-06-19 13:54   ` Mimi Zohar
2019-06-19 18:08     ` prakhar srivastava
2019-06-19 18:37       ` Mimi Zohar [this message]
2019-06-17 18:35 ` [PATCH 3/3] KEXEC:Call ima_kexec_cmdline to measure the boot command line args Prakhar Srivastava

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560969426.3975.64.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=prsriva02@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git