Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] smack: fix an compile error in smack_post_notification
@ 2019-09-23  3:16 zhong jiang
  2019-09-23  5:17 ` kbuild test robot
  2019-09-23 21:49 ` Casey Schaufler
  0 siblings, 2 replies; 3+ messages in thread
From: zhong jiang @ 2019-09-23  3:16 UTC (permalink / raw)
  To: casey; +Cc: jmorris, serge, linux-security-module, zhongjiang, linux-kernel

I hit the following error when compile the kernel.

security/smack/smack_lsm.c: In function smack_post_notification:
security/smack/smack_lsm.c:4383:7: error: dereferencing pointer to incomplete type struct watch_notification
  if (n->type == WATCH_TYPE_META)
       ^~
security/smack/smack_lsm.c:4383:17: error: WATCH_TYPE_META undeclared (first use in this function); did you mean TCA_PIE_BETA?
  if (n->type == WATCH_TYPE_META)
                 ^~~~~~~~~~~~~~~
                 TCA_PIE_BETA
security/smack/smack_lsm.c:4383:17: note: each undeclared identifier is reported only once for each function it appears in

Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
 security/smack/smack.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/security/smack/smack.h b/security/smack/smack.h
index 62529f3..02b05a2 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -21,6 +21,7 @@
 #include <linux/rculist.h>
 #include <linux/lsm_audit.h>
 #include <linux/msg.h>
+#include <linux/watch_queue.h>
 
 /*
  * Use IPv6 port labeling if IPv6 is enabled and secmarks
-- 
1.7.12.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] smack: fix an compile error in smack_post_notification
  2019-09-23  3:16 [PATCH] smack: fix an compile error in smack_post_notification zhong jiang
@ 2019-09-23  5:17 ` kbuild test robot
  2019-09-23 21:49 ` Casey Schaufler
  1 sibling, 0 replies; 3+ messages in thread
From: kbuild test robot @ 2019-09-23  5:17 UTC (permalink / raw)
  To: zhong jiang
  Cc: kbuild-all, casey, jmorris, serge, linux-security-module,
	zhongjiang, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 1722 bytes --]

Hi zhong,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.3 next-20190920]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/zhong-jiang/smack-fix-an-compile-error-in-smack_post_notification/20190923-112403
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   In file included from security/smack/smack_lsm.c:45:0:
>> security/smack/smack.h:24:10: fatal error: linux/watch_queue.h: No such file or directory
    #include <linux/watch_queue.h>
             ^~~~~~~~~~~~~~~~~~~~~
   compilation terminated.

vim +24 security/smack/smack.h

    11	
    12	#include <linux/capability.h>
    13	#include <linux/spinlock.h>
    14	#include <linux/lsm_hooks.h>
    15	#include <linux/in.h>
    16	#if IS_ENABLED(CONFIG_IPV6)
    17	#include <linux/in6.h>
    18	#endif /* CONFIG_IPV6 */
    19	#include <net/netlabel.h>
    20	#include <linux/list.h>
    21	#include <linux/rculist.h>
    22	#include <linux/lsm_audit.h>
    23	#include <linux/msg.h>
  > 24	#include <linux/watch_queue.h>
    25	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 70053 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] smack: fix an compile error in smack_post_notification
  2019-09-23  3:16 [PATCH] smack: fix an compile error in smack_post_notification zhong jiang
  2019-09-23  5:17 ` kbuild test robot
@ 2019-09-23 21:49 ` Casey Schaufler
  1 sibling, 0 replies; 3+ messages in thread
From: Casey Schaufler @ 2019-09-23 21:49 UTC (permalink / raw)
  To: zhong jiang; +Cc: jmorris, serge, linux-security-module, linux-kernel

On 9/22/2019 8:16 PM, zhong jiang wrote:
> I hit the following error when compile the kernel.

What tree/branch are you working with? I don't see this.

>
> security/smack/smack_lsm.c: In function smack_post_notification:
> security/smack/smack_lsm.c:4383:7: error: dereferencing pointer to incomplete type struct watch_notification
>   if (n->type == WATCH_TYPE_META)
>        ^~
> security/smack/smack_lsm.c:4383:17: error: WATCH_TYPE_META undeclared (first use in this function); did you mean TCA_PIE_BETA?
>   if (n->type == WATCH_TYPE_META)
>                  ^~~~~~~~~~~~~~~
>                  TCA_PIE_BETA
> security/smack/smack_lsm.c:4383:17: note: each undeclared identifier is reported only once for each function it appears in
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
>  security/smack/smack.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index 62529f3..02b05a2 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -21,6 +21,7 @@
>  #include <linux/rculist.h>
>  #include <linux/lsm_audit.h>
>  #include <linux/msg.h>
> +#include <linux/watch_queue.h>
>  
>  /*
>   * Use IPv6 port labeling if IPv6 is enabled and secmarks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-23  3:16 [PATCH] smack: fix an compile error in smack_post_notification zhong jiang
2019-09-23  5:17 ` kbuild test robot
2019-09-23 21:49 ` Casey Schaufler

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org
	public-inbox-index linux-security-module

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git