From: Roberto Sassu <roberto.sassu@huawei.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: <zohar@linux.ibm.com>, <david.safford@ge.com>,
<monty.wiseman@ge.com>, <linux-integrity@vger.kernel.org>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <silviu.vlasceanu@huawei.com>
Subject: Re: [PATCH v5 2/7] tpm: remove definition of TPM2_ACTIVE_PCR_BANKS
Date: Wed, 28 Nov 2018 13:17:22 +0100 [thread overview]
Message-ID: <1602133e-6a41-ea97-d985-6eca0831898d@huawei.com> (raw)
In-Reply-To: <20181116133851.GB4163@linux.intel.com>
On 11/16/2018 2:38 PM, Jarkko Sakkinen wrote:
> On Wed, Nov 14, 2018 at 04:31:03PM +0100, Roberto Sassu wrote:
>> tcg_efi_specid_event and tcg_pcr_event2 declaration contains static arrays
>> for a list of hash algorithms used for event logs and event log digests.
>>
>> However, according to TCG EFI Protocol Specification, these arrays have
>> variable sizes. Setting the array size to zero or 3 does not make any
>> difference, because the parser has to adjust the offset depending on the
>> actual array size to access structure members after the static arrays.
>>
>> Thus, this patch removes the declaration of TPM2_ACTIVE_PCR_BANKS and sets
>> the array size to zero.
>>
>> Fixes: 4d23cc323cdb ("tpm: add securityfs support for TPM 2.0 firmware
>> event log")
>>
>> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
>> ---
>> include/linux/tpm_eventlog.h | 5 ++---
>> 1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/include/linux/tpm_eventlog.h b/include/linux/tpm_eventlog.h
>> index 20d9da77fc11..3d5d162f09cc 100644
>> --- a/include/linux/tpm_eventlog.h
>> +++ b/include/linux/tpm_eventlog.h
>> @@ -8,7 +8,6 @@
>> #define TCG_EVENT_NAME_LEN_MAX 255
>> #define MAX_TEXT_EVENT 1000 /* Max event string length */
>> #define ACPI_TCPA_SIG "TCPA" /* 0x41504354 /'TCPA' */
>> -#define TPM2_ACTIVE_PCR_BANKS 3
>>
>> #define EFI_TCG2_EVENT_LOG_FORMAT_TCG_1_2 0x1
>> #define EFI_TCG2_EVENT_LOG_FORMAT_TCG_2 0x2
>> @@ -90,7 +89,7 @@ struct tcg_efi_specid_event {
>> u8 spec_errata;
>> u8 uintnsize;
>> u32 num_algs;
>> - struct tcg_efi_specid_event_algs digest_sizes[TPM2_ACTIVE_PCR_BANKS];
>> + struct tcg_efi_specid_event_algs digest_sizes[0];
>> u8 vendor_info_size;
>> u8 vendor_info[0];
>> } __packed;
>> @@ -117,7 +116,7 @@ struct tcg_pcr_event2 {
>> u32 pcr_idx;
>> u32 event_type;
>> u32 count;
>> - struct tpm2_digest digests[TPM2_ACTIVE_PCR_BANKS];
>> + struct tpm2_digest digests[0];
>> struct tcg_event_field event;
>> } __packed;
>>
>> --
>> 2.17.1
>>
>
> NAK for the same reason as last time.
I added this comment to include/linux/tpm_eventlog.h:
/*
* http://www.trustedcomputinggroup.org/tcg-efi-protocol-specification/
*
* Set the size of 'digest_sizes' and 'digests', members of
tcg_efi_specid_event
* and tcg_pcr_event2, to zero. Structures with variable-sized arrays
placed
* midway are not suitable for type casting.
*/
Is it ok?
Thanks
Roberto
> /Jarkko
>
--
HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063
Managing Director: Bo PENG, Jian LI, Yanli SHI
next prev parent reply other threads:[~2018-11-28 12:17 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 15:31 [PATCH v5 0/7] tpm: retrieve digest size of unknown algorithms from TPM Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 1/7] tpm: dynamically allocate the allocated_banks array Roberto Sassu
2018-11-16 13:36 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 2/7] tpm: remove definition of TPM2_ACTIVE_PCR_BANKS Roberto Sassu
2018-11-16 13:38 ` Jarkko Sakkinen
2018-11-28 7:50 ` Roberto Sassu
2018-11-28 12:17 ` Roberto Sassu [this message]
2018-11-29 12:04 ` Roberto Sassu
2018-11-30 19:41 ` Jarkko Sakkinen
2018-11-30 19:45 ` Jarkko Sakkinen
2018-11-30 22:18 ` Jarkko Sakkinen
2018-12-03 9:59 ` Roberto Sassu
2018-12-03 17:31 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 3/7] tpm: rename and export tpm2_digest and tpm2_algorithms Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 4/7] tpm: modify tpm_pcr_read() definition to pass a TPM hash algorithm Roberto Sassu
2018-11-16 13:41 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 5/7] tpm: retrieve digest size of unknown algorithms with PCR read Roberto Sassu
2018-11-14 15:31 ` [PATCH v5 6/7] tpm: ensure that the output of PCR read contains the correct digest size Roberto Sassu
2018-11-16 13:41 ` Jarkko Sakkinen
2018-11-16 16:06 ` Roberto Sassu
2018-11-18 7:32 ` Jarkko Sakkinen
2018-11-19 8:14 ` Roberto Sassu
2018-11-19 14:33 ` Jarkko Sakkinen
2018-11-19 15:09 ` Roberto Sassu
2018-11-19 16:07 ` Jarkko Sakkinen
2018-11-28 8:40 ` Roberto Sassu
2018-11-28 19:19 ` Jarkko Sakkinen
2018-11-14 15:31 ` [PATCH v5 7/7] tpm: pass an array of tpm_bank_list structures to tpm_pcr_extend() Roberto Sassu
2018-11-16 15:03 ` Jarkko Sakkinen
2018-11-16 15:55 ` Roberto Sassu
2018-11-18 7:27 ` Jarkko Sakkinen
2018-11-19 4:57 ` Mimi Zohar
2018-11-19 8:16 ` Roberto Sassu
2018-11-19 14:33 ` Mimi Zohar
2018-11-19 14:39 ` Jarkko Sakkinen
2018-11-18 7:29 ` Jarkko Sakkinen
2018-11-19 8:22 ` Roberto Sassu
2018-11-19 14:42 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602133e-6a41-ea97-d985-6eca0831898d@huawei.com \
--to=roberto.sassu@huawei.com \
--cc=david.safford@ge.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=monty.wiseman@ge.com \
--cc=silviu.vlasceanu@huawei.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).