linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Aaron Goidel <acgoide@tycho.nsa.gov>, <selinux@vger.kernel.org>,
	LSM List <linux-security-module@vger.kernel.org>,
	"linux-fsdevel" <linux-fsdevel@vger.kernel.org>,
	David Howells <dhowells@redhat.com>, Jan Kara <jack@suse.cz>,
	James Morris <jmorris@namei.org>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	"linux-kernel" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications
Date: Sat, 10 Aug 2019 11:01:16 -0400	[thread overview]
Message-ID: <16c7c0c4a60.280e.85c95baa4474aabc7814e68940a78392@paul-moore.com> (raw)
In-Reply-To: <CAOQ4uxiGNXbZ-DWeXTkNM4ySFbBbo1XOF1=3pjknsf+EjbNuOw@mail.gmail.com>

On August 10, 2019 6:05:27 AM Amir Goldstein <amir73il@gmail.com> wrote:

>>>> Other than Casey's comments, and ACK, I'm not seeing much commentary
>>>> on this patch so FS and LSM folks consider this your last chance - if
>>>> I don't hear any objections by the end of this week I'll plan on
>>>> merging this into selinux/next next week.
>>>
>>> Please consider it is summer time so people may be on vacation like I was...
>>
>> This is one of the reasons why I was speaking to the mailing list and
>> not a particular individual :)
>
> Jan is fsnotify maintainer, so I think you should wait for an explicit ACK
> from Jan or just merge the hook definition and ask Jan to merge to
> fsnotify security hooks.

Aaron posted his first patch a month ago in the beginning of July and I don't recall seeing any comments from Jan on any of the patch revisions. I would feel much better with an ACK/Reviewed-by from Jan, or you - which is why I sent that email - but I'm not going to wait forever and I'd like to get this into -next soon so we can get some testing.

--
paul moore
www.paul-moore.com




  reply	other threads:[~2019-08-10 15:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-31 15:34 [PATCH] fanotify, inotify, dnotify, security: add security hook for fs notifications Aaron Goidel
2019-07-31 17:26 ` Casey Schaufler
2019-08-01  0:27   ` Paul Moore
2019-08-01 11:31     ` Stephen Smalley
2019-08-01 12:47       ` Paul Moore
2019-08-08 18:33 ` Paul Moore
2019-08-09  9:06   ` Amir Goldstein
2019-08-09 12:55     ` Paul Moore
2019-08-09 15:44       ` [Non-DoD Source] " Aaron Goidel
2019-08-09 16:29         ` Amir Goldstein
2019-08-10 10:05       ` Amir Goldstein
2019-08-10 15:01         ` Paul Moore [this message]
2019-08-12 13:41           ` Jan Kara
2019-08-12 13:49             ` [Non-DoD Source] " Aaron Goidel
2019-08-12 14:45             ` Paul Moore
2019-08-09 16:25     ` [Non-DoD Source] " Aaron Goidel
2019-08-09 16:43       ` Amir Goldstein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16c7c0c4a60.280e.85c95baa4474aabc7814e68940a78392@paul-moore.com \
    --to=paul@paul-moore.com \
    --cc=acgoide@tycho.nsa.gov \
    --cc=amir73il@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=jack@suse.cz \
    --cc=jmorris@namei.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).