From: akpm@linux-foundation.org (Andrew Morton)
To: linux-security-module@vger.kernel.org
Subject: [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name
Date: Mon, 10 Sep 2018 15:09:03 -0700 [thread overview]
Message-ID: <20180910150903.249031442dd7fe43e01812cf@linux-foundation.org> (raw)
In-Reply-To: <20180909220018.GH13219@asgard.redhat.com>
On Mon, 10 Sep 2018 00:00:18 +0200 Eugene Syromiatnikov <esyr@redhat.com> wrote:
> On Tue, Aug 28, 2018 at 04:34:04PM -0700, Randy Dunlap wrote:
> > From: Randy Dunlap <rdunlap@infradead.org>
> >
> > Since this header is in "include/uapi/linux/", apparently people
> > want to use it in userspace programs -- even in C++ ones.
> > However, the header uses a C++ reserved keyword ("private"),
> > so change that to "dh_private" instead to allow the header file
> > to be used in C++ userspace.
>
> This change breaks all existing C programs that rely on <linux/keyctl.h>
> uapi header in order to get struct keyctl_dh_params definition, however.
Are there such programs? Do they reference the `private' field?
next prev parent reply other threads:[~2018-09-10 22:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-28 23:34 [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name Randy Dunlap
2018-08-29 2:42 ` Greg KH
2018-08-29 22:56 ` Andrew Morton
2018-09-09 22:00 ` Eugene Syromiatnikov
2018-09-10 22:09 ` Andrew Morton [this message]
2018-09-22 0:03 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910150903.249031442dd7fe43e01812cf@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).