From: Oleg Nesterov <oleg@redhat.com>
To: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: serge@hallyn.com,
syzbot <syzbot+a9ac39bf55329e206219@syzkaller.appspotmail.com>,
jmorris@namei.org, keescook@chromium.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org,
syzkaller-bugs@googlegroups.com
Subject: Re: KASAN: use-after-free Read in task_is_descendant
Date: Mon, 22 Oct 2018 11:54:39 +0200 [thread overview]
Message-ID: <20181022095439.GA4613@redhat.com> (raw)
In-Reply-To: <bf1a083c-0d09-07fb-6ad2-4bf30ac49cd8@I-love.SAKURA.ne.jp>
On 10/21, Tetsuo Handa wrote:
>
> On 2018/10/21 16:10, syzbot wrote:
> > BUG: KASAN: use-after-free in __read_once_size include/linux/compiler.h:188 [inline]
> > BUG: KASAN: use-after-free in task_is_descendant.part.2+0x610/0x670 security/yama/yama_lsm.c:295
> > Read of size 8 at addr ffff8801c4666b20 by task syz-executor3/12722
> >
> > CPU: 1 PID: 12722 Comm: syz-executor3 Not tainted 4.19.0-rc8+ #70
> > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
> > Call Trace:
> > __dump_stack lib/dump_stack.c:77 [inline]
> > dump_stack+0x1c4/0x2b4 lib/dump_stack.c:113
> > print_address_description.cold.8+0x9/0x1ff mm/kasan/report.c:256
> > kasan_report_error mm/kasan/report.c:354 [inline]
> > kasan_report.cold.9+0x242/0x309 mm/kasan/report.c:412
> > __asan_report_load8_noabort+0x14/0x20 mm/kasan/report.c:433
> > __read_once_size include/linux/compiler.h:188 [inline]
> > task_is_descendant.part.2+0x610/0x670 security/yama/yama_lsm.c:295
>
> Do we need to hold
>
> write_lock_irq(&tasklist_lock);
>
> rather than
>
> rcu_read_lock();
>
> when accessing
>
> "struct task_struct"->real_parent
Well, if "task" is stable (can't exit), then I think
rcu_dereference(task->real_parent)
is fine, we know that ->real_parent did not pass exit_notif() yet.
However, task_is_descendant() looks unnecessarily complicated, it could be
static int task_is_descendant(struct task_struct *parent,
struct task_struct *child)
{
int rc = 0;
struct task_struct *walker;
if (!parent || !child)
return 0;
rcu_read_lock();
for (walker = child; walker->pid; walker = rcu_dereference(walker->real_parent))
if (same_thread_group(parent, walker)) {
rc = 1;
break;
}
rcu_read_unlock();
return rc;
}
And again, I do not know how/if yama ensures that child is rcu-protected, perhaps
task_is_descendant() needs to check pid_alive(child) right after rcu_read_lock() ?
Oleg.
next prev parent reply other threads:[~2018-10-22 9:54 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-21 7:10 KASAN: use-after-free Read in task_is_descendant syzbot
2018-10-21 7:12 ` Tetsuo Handa
2018-10-22 9:54 ` Oleg Nesterov [this message]
2018-10-22 10:06 ` Tetsuo Handa
2018-10-22 13:46 ` Oleg Nesterov
2018-10-25 2:15 ` Tetsuo Handa
2018-10-25 11:13 ` Oleg Nesterov
2018-10-25 11:36 ` Kees Cook
2018-10-25 12:05 ` Oleg Nesterov
2018-10-25 11:47 ` Tetsuo Handa
2018-10-25 12:17 ` Oleg Nesterov
2018-10-25 13:01 ` Oleg Nesterov
2018-10-26 16:09 ` Kees Cook
2018-10-29 12:23 ` Oleg Nesterov
2018-10-29 15:05 ` yama: unsafe usage of ptrace_relation->tracer Oleg Nesterov
2019-01-10 11:05 ` Tetsuo Handa
2019-01-10 18:47 ` Kees Cook
2019-01-16 17:40 ` Oleg Nesterov
2018-10-25 13:14 ` KASAN: use-after-free Read in task_is_descendant Tetsuo Handa
2018-10-25 15:55 ` Oleg Nesterov
2018-10-25 16:25 ` Oleg Nesterov
2018-10-26 12:23 ` Tetsuo Handa
2018-10-26 13:04 ` Oleg Nesterov
2018-10-26 13:51 ` Tetsuo Handa
2018-10-26 14:39 ` Oleg Nesterov
2018-10-26 15:04 ` Tetsuo Handa
2018-10-26 15:22 ` Oleg Nesterov
2018-10-25 8:19 ` Kees Cook
2018-10-25 11:52 ` Oleg Nesterov
2018-11-10 3:25 ` syzbot
2018-11-10 11:46 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181022095439.GA4613@redhat.com \
--to=oleg@redhat.com \
--cc=jmorris@namei.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=serge@hallyn.com \
--cc=syzbot+a9ac39bf55329e206219@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).