From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D770FECDE47 for ; Thu, 8 Nov 2018 18:52:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A009220825 for ; Thu, 8 Nov 2018 18:52:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A009220825 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727029AbeKIE3h (ORCPT ); Thu, 8 Nov 2018 23:29:37 -0500 Received: from mga04.intel.com ([192.55.52.120]:33629 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726751AbeKIE3h (ORCPT ); Thu, 8 Nov 2018 23:29:37 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Nov 2018 10:52:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,480,1534834800"; d="scan'208";a="106464378" Received: from smartikx-mobl2.ger.corp.intel.com (HELO localhost) ([10.249.254.135]) by fmsmga001.fm.intel.com with ESMTP; 08 Nov 2018 10:52:44 -0800 Date: Thu, 8 Nov 2018 20:52:43 +0200 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v4 6/6] tpm: ensure that the output of PCR read contains the correct digest size Message-ID: <20181108185243.GA20608@linux.intel.com> References: <20181106150159.1136-1-roberto.sassu@huawei.com> <20181106150159.1136-7-roberto.sassu@huawei.com> <20181108140814.GF8922@linux.intel.com> <353ac2d0-591f-f950-f3ad-18e6a4f6085c@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <353ac2d0-591f-f950-f3ad-18e6a4f6085c@huawei.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Thu, Nov 08, 2018 at 03:47:39PM +0100, Roberto Sassu wrote: > > > + for (i = 0; i < chip->nr_active_banks && > > > + chip->active_banks[i].alg_id != digest_struct->alg_id; i++) > > > + ; > > > > Not sure if the semicolon should be in its own line. > > scripts/Lindent suggests: > > for (i = 0; i < chip->nr_active_banks && > chip->active_banks[i].alg_id != digest_struct->alg_id; > i++) ; > > but this is not accepted by scripts/checkpatch.pl (there are no > warnings/errors on the patch I sent). Yeah, not a really blocker for me. Reviewed-by: Jarkko Sakkinen /Jarkko