From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0833C43441 for ; Tue, 13 Nov 2018 16:59:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74A7522360 for ; Tue, 13 Nov 2018 16:59:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74A7522360 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728745AbeKNC62 (ORCPT ); Tue, 13 Nov 2018 21:58:28 -0500 Received: from mga18.intel.com ([134.134.136.126]:63148 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727042AbeKNC62 (ORCPT ); Tue, 13 Nov 2018 21:58:28 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2018 08:59:29 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,228,1539673200"; d="scan'208";a="90807242" Received: from ibanaga-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.77]) by orsmga006.jf.intel.com with ESMTP; 13 Nov 2018 08:59:26 -0800 Date: Tue, 13 Nov 2018 18:59:24 +0200 From: Jarkko Sakkinen To: Roberto Sassu Cc: zohar@linux.ibm.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v4 6/6] tpm: ensure that the output of PCR read contains the correct digest size Message-ID: <20181113165924.GC4752@linux.intel.com> References: <20181106150159.1136-1-roberto.sassu@huawei.com> <20181106150159.1136-7-roberto.sassu@huawei.com> <20181108140814.GF8922@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Tue, Nov 13, 2018 at 02:08:39PM +0100, Roberto Sassu wrote: > On 11/8/2018 3:08 PM, Jarkko Sakkinen wrote: > > On Tue, Nov 06, 2018 at 04:01:59PM +0100, Roberto Sassu wrote: > > > This patch protects against data corruption that could happen in the bus, > > > by checking that that the digest size returned by the TPM during a PCR read > > > matches the size of the algorithm passed as argument to tpm2_pcr_read(). > > > > > > This check is performed after information about the PCR banks has been > > > retrieved. > > > > > > Signed-off-by: Roberto Sassu > > > --- > > > drivers/char/tpm/tpm2-cmd.c | 16 +++++++++++++++- > > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > > > diff --git a/drivers/char/tpm/tpm2-cmd.c b/drivers/char/tpm/tpm2-cmd.c > > > index e2d5b84286a7..3b0b5b032901 100644 > > > --- a/drivers/char/tpm/tpm2-cmd.c > > > +++ b/drivers/char/tpm/tpm2-cmd.c > > > @@ -187,15 +187,28 @@ struct tpm2_pcr_read_out { > > > int tpm2_pcr_read(struct tpm_chip *chip, int pcr_idx, > > > struct tpm_digest *digest_struct, u16 *digest_size_ptr) > > > { > > > + int i; > > > int rc; > > > struct tpm_buf buf; > > > struct tpm2_pcr_read_out *out; > > > u8 pcr_select[TPM2_PCR_SELECT_MIN] = {0}; > > > u16 digest_size; > > > + u16 expected_digest_size = 0; > > > if (pcr_idx >= TPM2_PLATFORM_PCR) > > > return -EINVAL; > > > + if (!digest_size_ptr) { > > > + for (i = 0; i < chip->nr_active_banks && > > > + chip->active_banks[i].alg_id != digest_struct->alg_id; i++) > > > + ; > > > > Not sure if the semicolon should be in its own line. > > ` > > > + > > > + if (i == chip->nr_active_banks) > > > + return -EINVAL; > > > + > > > + expected_digest_size = chip->active_banks[i].digest_size; > > > + } > > > + > > > rc = tpm_buf_init(&buf, TPM2_ST_NO_SESSIONS, TPM2_CC_PCR_READ); > > > if (rc) > > > return rc; > > > @@ -215,7 +228,8 @@ int tpm2_pcr_read(struct tpm_chip *chip, int pcr_idx, > > > out = (struct tpm2_pcr_read_out *)&buf.data[TPM_HEADER_SIZE]; > > > digest_size = be16_to_cpu(out->digest_size); > > > - if (digest_size > sizeof(digest_struct->digest)) { > > > + if (digest_size > sizeof(digest_struct->digest) || > > > + (!digest_size_ptr && digest_size != expected_digest_size)) { > > > rc = -EINVAL; > > > goto out; > > > } > > > -- > > > 2.17.1 > > > > > > > Please add > > > > Cc: stable@vger.kernel.org. > > Should I do the same for the previous patches? This patch cannot be > applied alone. > > Roberto No need. It is an issue that we deal with depenendent commits once it is being backported. This could be dependent for example of a commit that is even not in the series so does not make sense to do it now. /Jarkko