From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0C4FC43441 for ; Mon, 19 Nov 2018 15:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6299020831 for ; Mon, 19 Nov 2018 15:55:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6299020831 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-security-module-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729792AbeKTCTg (ORCPT ); Mon, 19 Nov 2018 21:19:36 -0500 Received: from mga01.intel.com ([192.55.52.88]:60260 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729762AbeKTCTf (ORCPT ); Mon, 19 Nov 2018 21:19:35 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Nov 2018 07:55:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,253,1539673200"; d="scan'208";a="109536116" Received: from tmuluk-mobl4.ger.corp.intel.com (HELO localhost) ([10.249.254.135]) by orsmga001.jf.intel.com with ESMTP; 19 Nov 2018 07:55:31 -0800 Date: Mon, 19 Nov 2018 17:55:30 +0200 From: Jarkko Sakkinen To: "Winkler, Tomas" Cc: "linux-integrity@vger.kernel.org" , "linux-security-module@vger.kernel.org" , James Bottomley , "Struk, Tadeusz" , Stefan Berger , Nayna Jain , Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg Kroah-Hartman , open list Subject: Re: [PATCH v9 16/17] tpm: take TPM chip power gating out of tpm_transmit() Message-ID: <20181119155530.GB13298@linux.intel.com> References: <20181118124753.18613-1-jarkko.sakkinen@linux.intel.com> <20181118124753.18613-17-jarkko.sakkinen@linux.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9DA225B9@hasmsx108.ger.corp.intel.com> <20181119124822.GB8755@linux.intel.com> <5B8DA87D05A7694D9FA63FD143655C1B9DA230D9@hasmsx108.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9DA230D9@hasmsx108.ger.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Nov 19, 2018 at 01:17:56PM +0000, Winkler, Tomas wrote: > > On Sun, Nov 18, 2018 at 10:52:46PM +0000, Winkler, Tomas wrote: > > > This is still NACK from my side > > > > Last time you spoke about tboot intervention but I don't see why as even > > sending a single command is not atomic in the true sense of the word i.e. if > > there was a problem that would already affect the existing code and would > > essentially mean that tboot itself is broken. > So I've consulted the issue, I wasn't not correct in the description. > Tboot cannot acquire the locality, unless the host driver relinquish > it, so the issue is opposite, driver is expected to relinquish the > locality for tboot to work correctly. This is current status, other > behavior will need a different implementation on both sides. The locality is reliquished after the command sequence (load and save TPM space + command in /dev/tpmX case). Is this really such a big issue? The intention is not keep the locality reserved by the driver. /Jarkko