From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tadeusz Struk <tadeusz.struk@intel.com>
Cc: jgg@ziepe.ca, linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] tpm: add support for partial reads
Date: Wed, 21 Nov 2018 08:45:39 +0200 [thread overview]
Message-ID: <20181121064539.GB3640@linux.intel.com> (raw)
In-Reply-To: <affa9788-9d86-341f-28fb-66a8720ef697@intel.com>
On Tue, Nov 20, 2018 at 03:13:59PM -0800, Tadeusz Struk wrote:
> On 11/20/18 3:07 PM, Jarkko Sakkinen wrote:
> >>>> + /* Holds the resul of the last successful call to tpm_transmit() */
> >>> This comment is cruft.
> >> Do you want me to remove it? This is the comment you proposed.
> > As I explained before it made sense before you made the remark that
> > it can only get positive values i.e. the length.
> >
> So what do you want me to do with this one?
I don't think it needs now any comment because the variable describes
itself so well.
/Jarkko
prev parent reply other threads:[~2018-11-21 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 18:55 [PATCH v5] tpm: add support for partial reads Tadeusz Struk
2018-11-20 12:48 ` Jarkko Sakkinen
2018-11-20 18:30 ` Tadeusz Struk
2018-11-20 23:09 ` Jarkko Sakkinen
2018-11-20 18:36 ` Tadeusz Struk
2018-11-20 23:07 ` Jarkko Sakkinen
2018-11-20 23:13 ` Tadeusz Struk
2018-11-21 6:45 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181121064539.GB3640@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).