From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EC5EC282D7 for ; Tue, 5 Feb 2019 08:53:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5EFA32175B for ; Tue, 5 Feb 2019 08:53:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alien8.de header.i=@alien8.de header.b="dFRXAToX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727038AbfBEIx1 (ORCPT ); Tue, 5 Feb 2019 03:53:27 -0500 Received: from mail.skyhub.de ([5.9.137.197]:45512 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725898AbfBEIx1 (ORCPT ); Tue, 5 Feb 2019 03:53:27 -0500 Received: from zn.tnic (p200300EC2BCB6B008896F3D5E1C66173.dip0.t-ipconnect.de [IPv6:2003:ec:2bcb:6b00:8896:f3d5:e1c6:6173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 955EB1EC02AE; Tue, 5 Feb 2019 09:53:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1549356805; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=9NPvfNG+JFpDM7sjiNkdW+XpScH5VeiM2qlV0JoY6ZA=; b=dFRXAToX5/08SPN0allQ11aILUZsmqf1gG1hG+VKNk9k/KbmUKs/QtkUV1Dckk8k5WEBri SbcwLdA6zuqezXnk0dN5d6IYdQlJsKW0k1gguU0W6REBUNatrwKiZt6E8IsZhciVrJH0CU WTpRddr5zmzLbrlGnkZkBIBx+ZjWfJ4= Date: Tue, 5 Feb 2019 09:53:11 +0100 From: Borislav Petkov To: Rick Edgecombe Cc: Andy Lutomirski , Ingo Molnar , linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com, Thomas Gleixner , Nadav Amit , Dave Hansen , Peter Zijlstra , linux_dti@icloud.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, akpm@linux-foundation.org, kernel-hardening@lists.openwall.com, linux-mm@kvack.org, will.deacon@arm.com, ard.biesheuvel@linaro.org, kristen@linux.intel.com, deneen.t.dock@intel.com, Nadav Amit , Kees Cook , Dave Hansen Subject: Re: [PATCH v2 04/20] fork: provide a function for copying init_mm Message-ID: <20190205085311.GH21801@zn.tnic> References: <20190129003422.9328-1-rick.p.edgecombe@intel.com> <20190129003422.9328-5-rick.p.edgecombe@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190129003422.9328-5-rick.p.edgecombe@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Jan 28, 2019 at 04:34:06PM -0800, Rick Edgecombe wrote: > From: Nadav Amit > > Provide a function for copying init_mm. This function will be later used > for setting a temporary mm. > > Cc: Andy Lutomirski > Cc: Kees Cook > Cc: Dave Hansen > Acked-by: Peter Zijlstra (Intel) > Reviewed-by: Masami Hiramatsu > Tested-by: Masami Hiramatsu > Signed-off-by: Nadav Amit > Signed-off-by: Rick Edgecombe > --- > include/linux/sched/task.h | 1 + > kernel/fork.c | 24 ++++++++++++++++++------ > 2 files changed, 19 insertions(+), 6 deletions(-) > > diff --git a/include/linux/sched/task.h b/include/linux/sched/task.h > index 44c6f15800ff..c5a00a7b3beb 100644 > --- a/include/linux/sched/task.h > +++ b/include/linux/sched/task.h > @@ -76,6 +76,7 @@ extern void exit_itimers(struct signal_struct *); > extern long _do_fork(unsigned long, unsigned long, unsigned long, int __user *, int __user *, unsigned long); > extern long do_fork(unsigned long, unsigned long, unsigned long, int __user *, int __user *); > struct task_struct *fork_idle(int); > +struct mm_struct *copy_init_mm(void); > extern pid_t kernel_thread(int (*fn)(void *), void *arg, unsigned long flags); > extern long kernel_wait4(pid_t, int __user *, int, struct rusage *); > > diff --git a/kernel/fork.c b/kernel/fork.c > index b69248e6f0e0..d7b156c49f29 100644 > --- a/kernel/fork.c > +++ b/kernel/fork.c > @@ -1299,13 +1299,20 @@ void mm_release(struct task_struct *tsk, struct mm_struct *mm) > complete_vfork_done(tsk); > } > > -/* > - * Allocate a new mm structure and copy contents from the > - * mm structure of the passed in task structure. > +/** > + * dup_mm() - duplicates an existing mm structure > + * @tsk: the task_struct with which the new mm will be associated. > + * @oldmm: the mm to duplicate. > + * > + * Allocates a new mm structure and copy contents from the provided s/copy/copies/ -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.