From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C37FBC48BE8 for ; Sun, 23 Jun 2019 00:25:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 996B620862 for ; Sun, 23 Jun 2019 00:25:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="hGZBty9v" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726355AbfFWAZc (ORCPT ); Sat, 22 Jun 2019 20:25:32 -0400 Received: from mail-pf1-f194.google.com ([209.85.210.194]:40217 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbfFWAZa (ORCPT ); Sat, 22 Jun 2019 20:25:30 -0400 Received: by mail-pf1-f194.google.com with SMTP id p184so5442332pfp.7 for ; Sat, 22 Jun 2019 17:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Muy8l67XTgQ8QvvYzm/lgbWW8wIRKwYpaJ4/hlcS4jk=; b=hGZBty9vkwSEnFjKjjzvO41IQIGOS2M1st7Zs3Q2F5qYDxJa17E/2ppGWE/VoTbKE7 Ex+YYt8iotCN+AvqdKFQvogDBDELCpucsd4iGP9AfpIbPSn1IV8eFeA0d78v5BBaA1Yd VBtAB4e4wegcGRAoCgrMEViWixlEWgGZpr8bU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Muy8l67XTgQ8QvvYzm/lgbWW8wIRKwYpaJ4/hlcS4jk=; b=GHms1K/W44fsE6igE/qQ1Bcse347sOmW7O1NSTNnVdFN5b8rxNIvElpUANO142tltB x9QdKLqiTZFmGirmbK1oRN97e6v4lKXKsOrWe/tkAuOnP/9vvYgkM2/QxrEaNYDeAKtK yG9tatw2OHThNwLkJ+Wu9GSwNY8woE5tDxsQbS/Ul+Ni87+w0Lx0gXk8i59iMR97Cxgq 4a7iZQ0u6vDkaygeXMXPrPbUoaS2YyYiLLtRsVNRL8qdhbwEXP0wFf98/iHg7wNggTDe qQXRhswUZEKPG3hvGz2Ro/9HJY2wz4d3CQItk8R0rI2+sCHhwqKVDO2GzypZ+9Ga1XNt udAQ== X-Gm-Message-State: APjAAAWzOTeD93qWuXkrYNN8ZH6+IqQFJUeyqaSvCKfIzF1ZXZnsuIb/ N65DC/gcGiFLpZeyCC0Y3NQT5A== X-Google-Smtp-Source: APXvYqyfE7pyqOmRt//qF5dntnKG8qFiDNfEU/crAJj6CQbY7HT06JFeATqZu/GBxAPBGY+3arfbxQ== X-Received: by 2002:a17:90b:d8a:: with SMTP id bg10mr15802946pjb.92.1561249530062; Sat, 22 Jun 2019 17:25:30 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id e20sm6764757pfi.35.2019.06.22.17.25.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 22 Jun 2019 17:25:28 -0700 (PDT) Date: Sat, 22 Jun 2019 17:25:28 -0700 From: Kees Cook To: Matthew Garrett Cc: jmorris@namei.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, David Howells , Matthew Garrett Subject: Re: [PATCH V34 29/29] lockdown: Print current->comm in restriction messages Message-ID: <201906221724.EF1BA1D@keescook> References: <20190622000358.19895-1-matthewgarrett@google.com> <20190622000358.19895-30-matthewgarrett@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190622000358.19895-30-matthewgarrett@google.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Fri, Jun 21, 2019 at 05:03:58PM -0700, Matthew Garrett wrote: > Print the content of current->comm in messages generated by lockdown to > indicate a restriction that was hit. This makes it a bit easier to find > out what caused the message. > > The message now patterned something like: > > Lockdown: : is restricted; see man kernel_lockdown.7 > > Signed-off-by: David Howells > Signed-off-by: Matthew Garrett > --- > security/lockdown/lockdown.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/security/lockdown/lockdown.c b/security/lockdown/lockdown.c > index 98f9ee0026d5..9ca6f442fbc7 100644 > --- a/security/lockdown/lockdown.c > +++ b/security/lockdown/lockdown.c > @@ -83,8 +83,8 @@ static int lockdown_is_locked_down(enum lockdown_reason what) > { > if ((kernel_locked_down >= what)) { To satisfy my paranoia, can you just add here: if (WARN(what > LOCKDOWN_..._MAX)) return -EPERM; With that: Reviewed-by: Kees Cook -Kees > if (lockdown_reasons[what]) > - pr_notice("Lockdown: %s is restricted; see man kernel_lockdown.7\n", > - lockdown_reasons[what]); > + pr_notice("Lockdown: %s: %s is restricted; see man kernel_lockdown.7\n", > + current->comm, lockdown_reasons[what]); > return -EPERM; > } > > -- > 2.22.0.410.gd8fdbe21b5-goog > -- Kees Cook