linux-security-module.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
	linux-crypto@vger.kernel.org,
	linux-security-module@vger.kernel.org, dhowells@redhat.com,
	herbert@gondor.apana.org.au, davem@davemloft.net,
	peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com,
	arnd@arndb.de, gregkh@linuxfoundation.org, zohar@linux.ibm.com,
	jmorris@namei.org, serge@hallyn.com, casey@schaufler-ca.com,
	ard.biesheuvel@linaro.org, daniel.thompson@linaro.org,
	linux-kernel@vger.kernel.org, tee-dev@lists.linaro.org
Subject: Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code
Date: Wed, 7 Aug 2019 22:03:44 +0300	[thread overview]
Message-ID: <20190807190320.th4sbnsnmwb7myzx@linux.intel.com> (raw)
In-Reply-To: <1565098640-12536-3-git-send-email-sumit.garg@linaro.org>

On Tue, Aug 06, 2019 at 07:07:19PM +0530, Sumit Garg wrote:
> Move TPM2 trusted keys code to trusted keys subsystem.

Missing a long description. The reason is that it is better consolidate
all trusted keys code to a single location so that it can be maintained
sanely and it should be stated here.

> Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Sumit Garg <sumit.garg@linaro.org>

I would suggest adding at least two commits before this:

- A commit that just exports tpm_buf stuff and TPM2 constants to
  include/linux
- A commit that just changes the existing TPM 1.x trusted keys
  code to use tpm_buf.

These should be before the current 1/3 commit.

/Jarkko

  parent reply	other threads:[~2019-08-07 19:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-06 13:37 [RFC/RFT v3 0/3] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2019-08-06 13:37 ` [RFC/RFT v3 1/3] KEYS: trusted: create trusted keys subsystem Sumit Garg
2019-08-07 18:59   ` Jarkko Sakkinen
2019-08-08 12:26     ` Sumit Garg
2019-08-06 13:37 ` [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code Sumit Garg
2019-08-06 13:43   ` Greg KH
2019-08-06 13:55     ` Sumit Garg
2019-08-07 19:03   ` Jarkko Sakkinen [this message]
2019-08-08 13:21     ` Sumit Garg
2019-08-08 15:15       ` Jarkko Sakkinen
2019-08-13  7:59         ` Sumit Garg
2019-08-06 13:37 ` [RFC/RFT v3 3/3] KEYS: trusted: Add generic trusted keys framework Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190807190320.th4sbnsnmwb7myzx@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=casey@schaufler-ca.com \
    --cc=daniel.thompson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jejb@linux.ibm.com \
    --cc=jgg@ziepe.ca \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=serge@hallyn.com \
    --cc=sumit.garg@linaro.org \
    --cc=tee-dev@lists.linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).