From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E39DC0650F for ; Thu, 8 Aug 2019 15:16:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1F28C218B8 for ; Thu, 8 Aug 2019 15:16:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732725AbfHHPQB (ORCPT ); Thu, 8 Aug 2019 11:16:01 -0400 Received: from mga14.intel.com ([192.55.52.115]:63160 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727096AbfHHPQB (ORCPT ); Thu, 8 Aug 2019 11:16:01 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Aug 2019 08:16:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,361,1559545200"; d="scan'208";a="350203764" Received: from sandersb-mobl.ger.corp.intel.com (HELO localhost) ([10.249.33.239]) by orsmga005.jf.intel.com with ESMTP; 08 Aug 2019 08:15:51 -0700 Date: Thu, 8 Aug 2019 18:15:50 +0300 From: Jarkko Sakkinen To: Sumit Garg Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , linux-security-module@vger.kernel.org, dhowells@redhat.com, Herbert Xu , davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com, Arnd Bergmann , Greg Kroah-Hartman , Mimi Zohar , James Morris , "Serge E. Hallyn" , Casey Schaufler , Ard Biesheuvel , Daniel Thompson , Linux Kernel Mailing List , "tee-dev @ lists . linaro . org" Subject: Re: [RFC/RFT v3 2/3] KEYS: trusted: move tpm2 trusted keys code Message-ID: <20190808151500.ypfcqowklalu76uq@linux.intel.com> References: <1565098640-12536-1-git-send-email-sumit.garg@linaro.org> <1565098640-12536-3-git-send-email-sumit.garg@linaro.org> <20190807190320.th4sbnsnmwb7myzx@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Thu, Aug 08, 2019 at 06:51:38PM +0530, Sumit Garg wrote: > It seems to be a functional change which I think requires proper unit > testing. I am afraid that I don't posses a TPM device to test this and > also very less conversant with tpm_buf code. > > So what I have done here is to rename existing TPM 1.x trusted keys > code to use tpm1_buf. > > And I would be happy to integrate a tested patch if anyone familiar > could work on this. I can test it on TPM 1.2. /Jarkko