From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BF9DC3A5A0 for ; Mon, 19 Aug 2019 17:06:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5784622CEA for ; Mon, 19 Aug 2019 17:06:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727268AbfHSRGl (ORCPT ); Mon, 19 Aug 2019 13:06:41 -0400 Received: from mga09.intel.com ([134.134.136.24]:60682 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726987AbfHSRGl (ORCPT ); Mon, 19 Aug 2019 13:06:41 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Aug 2019 10:06:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,405,1559545200"; d="scan'208";a="353304570" Received: from jsakkine-mobl1.tm.intel.com (HELO localhost) ([10.237.50.125]) by orsmga005.jf.intel.com with ESMTP; 19 Aug 2019 10:06:35 -0700 Date: Mon, 19 Aug 2019 20:06:35 +0300 From: Jarkko Sakkinen To: Sumit Garg Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org, linux-security-module@vger.kernel.org, dhowells@redhat.com, herbert@gondor.apana.org.au, davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca, jejb@linux.ibm.com, arnd@arndb.de, gregkh@linuxfoundation.org, zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com, casey@schaufler-ca.com, ard.biesheuvel@linaro.org, daniel.thompson@linaro.org, linux-kernel@vger.kernel.org, tee-dev@lists.linaro.org Subject: Re: [RFC/RFT v4 3/5] KEYS: trusted: create trusted keys subsystem Message-ID: <20190819170635.jlxxi6ogbm4s6gcx@linux.intel.com> References: <1565682784-10234-1-git-send-email-sumit.garg@linaro.org> <1565682784-10234-4-git-send-email-sumit.garg@linaro.org> <20190819170458.m7adhkji64kta32d@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190819170458.m7adhkji64kta32d@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: NeoMutt/20180716 Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Aug 19, 2019 at 08:04:58PM +0300, Jarkko Sakkinen wrote: > On Tue, Aug 13, 2019 at 01:23:02PM +0530, Sumit Garg wrote: > > Move existing code to trusted keys subsystem. Also, rename files with > > "tpm" as suffix which provides the underlying implementation. > > > > Suggested-by: Jarkko Sakkinen > > Signed-off-by: Sumit Garg > > --- > > crypto/asymmetric_keys/asym_tpm.c | 2 +- > > include/keys/{trusted.h => trusted_tpm.h} | 4 ++-- > > security/keys/Makefile | 2 +- > > security/keys/trusted-keys/Makefile | 7 +++++++ > > security/keys/{trusted.c => trusted-keys/trusted-tpm.c} | 2 +- > > 5 files changed, 12 insertions(+), 5 deletions(-) > > rename include/keys/{trusted.h => trusted_tpm.h} (98%) > > create mode 100644 security/keys/trusted-keys/Makefile > > rename security/keys/{trusted.c => trusted-keys/trusted-tpm.c} (99%) > > Would prefer trusted_tpm.c. Actually, trusted_tpm1.c. /Jarkko