Linux-Security-Module Archive on lore.kernel.org
 help / color / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sumit Garg <sumit.garg@linaro.org>
Cc: keyrings@vger.kernel.org, linux-integrity@vger.kernel.org,
	"open list:HARDWARE RANDOM NUMBER GENERATOR CORE" 
	<linux-crypto@vger.kernel.org>,
	linux-security-module@vger.kernel.org, dhowells@redhat.com,
	Herbert Xu <herbert@gondor.apana.org.au>,
	davem@davemloft.net, peterhuewe@gmx.de, jgg@ziepe.ca,
	jejb@linux.ibm.com, Arnd Bergmann <arnd@arndb.de>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Mimi Zohar <zohar@linux.ibm.com>,
	James Morris <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	Casey Schaufler <casey@schaufler-ca.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>
Subject: Re: [RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/
Date: Wed, 21 Aug 2019 22:13:54 +0300
Message-ID: <20190821191354.4redyuo5j2njkruy@linux.intel.com> (raw)
In-Reply-To: <CAFA6WYMoX95UcuGb2UdrUMnq=4wYJChwcMgm8pHHPs_Lg=5iNg@mail.gmail.com>

On Tue, Aug 20, 2019 at 11:22:05AM +0530, Sumit Garg wrote:
> On Mon, 19 Aug 2019 at 22:26, Jarkko Sakkinen
> <jarkko.sakkinen@linux.intel.com> wrote:
> >
> > On Tue, Aug 13, 2019 at 01:23:00PM +0530, Sumit Garg wrote:
> > > Move tpm_buf code to common include/linux/tpm.h header so that it can
> > > be reused via other subsystems like trusted keys etc.
> > >
> > > Also rename trusted keys TPM 1.x buffer implementation to tpm1_buf to
> > > avoid any compilation errors.
> > >
> > > Suggested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> >
> > A question: did you try to do this as mechanically as you ever could
> > or did you do any other code changes? I did go through it but it is
> > possible that I missed something.
> >
> 
> There aren't any other code changes apart from "tpm1_buf" rename.

Thanks. I had to ask because it would be hard to check it manually.

/Jarkko

  reply index

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-13  7:52 [RFC/RFT v4 0/5] Add generic trusted keys framework/subsystem Sumit Garg
2019-08-13  7:53 ` [RFC/RFT v4 1/5] tpm: move tpm_buf code to include/linux/ Sumit Garg
2019-08-19 16:56   ` Jarkko Sakkinen
2019-08-20  5:52     ` Sumit Garg
2019-08-21 19:13       ` Jarkko Sakkinen [this message]
2019-08-13  7:53 ` [RFC/RFT v4 2/5] KEYS: trusted: use common tpm_buf for TPM1.x code Sumit Garg
2019-08-19 16:57   ` Jarkko Sakkinen
2019-08-13  7:53 ` [RFC/RFT v4 3/5] KEYS: trusted: create trusted keys subsystem Sumit Garg
2019-08-19 17:04   ` Jarkko Sakkinen
2019-08-19 17:06     ` Jarkko Sakkinen
2019-08-20  5:53       ` Sumit Garg
2019-08-13  7:53 ` [RFC/RFT v4 4/5] KEYS: trusted: move tpm2 trusted keys code Sumit Garg
2019-08-19 17:07   ` Jarkko Sakkinen
2019-08-20  5:54     ` Sumit Garg
2019-08-13  7:53 ` [RFC/RFT v4 5/5] KEYS: trusted: Add generic trusted keys framework Sumit Garg
2019-08-30  9:19   ` Sumit Garg
2019-08-30 17:20     ` Jarkko Sakkinen
2019-08-30 17:24       ` Jarkko Sakkinen
2019-09-02  5:07         ` Sumit Garg
2019-08-14 13:24 ` [RFC/RFT v4 0/5] Add generic trusted keys framework/subsystem Mimi Zohar
2019-08-15 13:03   ` Sumit Garg
2019-08-15 15:06     ` Mimi Zohar
2019-08-16  4:58       ` Sumit Garg
2019-08-19 16:54 ` Jarkko Sakkinen
2019-08-20  5:46   ` Sumit Garg
2019-08-21 19:12     ` Jarkko Sakkinen

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190821191354.4redyuo5j2njkruy@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=arnd@arndb.de \
    --cc=casey@schaufler-ca.com \
    --cc=daniel.thompson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=jejb@linux.ibm.com \
    --cc=jgg@ziepe.ca \
    --cc=jmorris@namei.org \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=peterhuewe@gmx.de \
    --cc=serge@hallyn.com \
    --cc=sumit.garg@linaro.org \
    --cc=tee-dev@lists.linaro.org \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Security-Module Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-security-module/0 linux-security-module/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-security-module linux-security-module/ https://lore.kernel.org/linux-security-module \
		linux-security-module@vger.kernel.org linux-security-module@archiver.kernel.org
	public-inbox-index linux-security-module


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-security-module


AGPL code for this site: git clone https://public-inbox.org/ public-inbox