From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05D33C47404 for ; Fri, 11 Oct 2019 11:41:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DB5712084C for ; Fri, 11 Oct 2019 11:41:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727928AbfJKLlT (ORCPT ); Fri, 11 Oct 2019 07:41:19 -0400 Received: from mga07.intel.com ([134.134.136.100]:47805 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727883AbfJKLlT (ORCPT ); Fri, 11 Oct 2019 07:41:19 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2019 04:41:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.67,284,1566889200"; d="scan'208";a="200765694" Received: from mkaltenb-mobl.ger.corp.intel.com (HELO localhost) ([10.251.83.92]) by FMSMGA003.fm.intel.com with ESMTP; 11 Oct 2019 04:41:11 -0700 Date: Fri, 11 Oct 2019 14:41:05 +0300 From: Jarkko Sakkinen To: Sumit Garg Cc: dhowells@redhat.com, peterhuewe@gmx.de, keyrings@vger.kernel.org, linux-integrity@vger.kernel.org, linux-crypto@vger.kernel.org, linux-security-module@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, jgg@ziepe.ca, arnd@arndb.de, gregkh@linuxfoundation.org, jejb@linux.ibm.com, zohar@linux.ibm.com, jmorris@namei.org, serge@hallyn.com, jsnitsel@redhat.com, linux-kernel@vger.kernel.org, daniel.thompson@linaro.org Subject: Re: [Patch v7 1/4] tpm: Move tpm_buf code to include/linux/ Message-ID: <20191011114105.GA3129@linux.intel.com> References: <1570425935-7435-1-git-send-email-sumit.garg@linaro.org> <1570425935-7435-2-git-send-email-sumit.garg@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1570425935-7435-2-git-send-email-sumit.garg@linaro.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Oct 07, 2019 at 10:55:32AM +0530, Sumit Garg wrote: > Move tpm_buf code to common include/linux/tpm.h header so that it can > be reused via other subsystems like trusted keys etc. > > Also rename trusted keys and asymmetric keys usage of TPM 1.x buffer > implementation to tpm1_buf to avoid any compilation errors. > > Suggested-by: Jarkko Sakkinen > Signed-off-by: Sumit Garg > --- > crypto/asymmetric_keys/asym_tpm.c | 12 +-- > drivers/char/tpm/tpm.h | 215 -------------------------------------- > include/keys/trusted.h | 12 +-- > include/linux/tpm.h | 215 ++++++++++++++++++++++++++++++++++++++ > security/keys/trusted.c | 12 +-- > 5 files changed, 233 insertions(+), 233 deletions(-) Looks clean. Reviewed-by: Jarkko Sakkinen /Jarkko