From: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
To: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sam Ravnborg <sam@ravnborg.org>,
Grzegorz Halat <ghalat@redhat.com>
Cc: syzbot <syzbot+4455ca3b3291de891abc@syzkaller.appspotmail.com>,
aryabinin@virtuozzo.com, daniel.thompson@linaro.org,
dri-devel@lists.freedesktop.org, dvyukov@google.com,
gleb@kernel.org, gwshan@linux.vnet.ibm.com, hpa@zytor.com,
jmorris@namei.org, kasan-dev@googlegroups.com,
kvm@vger.kernel.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, mingo@redhat.com,
mpe@ellerman.id.au, pbonzini@redhat.com, ruscur@russell.cc,
serge@hallyn.com, stewart@linux.vnet.ibm.com,
syzkaller-bugs@googlegroups.com, takedakn@nttdata.co.jp,
tglx@linutronix.de, x86@kernel.org
Subject: Re: KASAN: slab-out-of-bounds Read in fbcon_get_font
Date: Thu, 05 Dec 2019 10:59:56 +0900 [thread overview]
Message-ID: <201912050159.xB51xuco020972@www262.sakura.ne.jp> (raw)
In-Reply-To: <0000000000003e640e0598e7abc3@google.com>
Hello.
syzbot is reporting that memory allocation size at fbcon_set_font() is too small
because font's height is rounded up from 10 to 16 after memory allocation.
----------
diff --git a/drivers/video/fbdev/core/fbcon.c b/drivers/video/fbdev/core/fbcon.c
index c9235a2f42f8..68fe66e435d3 100644
--- a/drivers/video/fbdev/core/fbcon.c
+++ b/drivers/video/fbdev/core/fbcon.c
@@ -2461,6 +2461,7 @@ static int fbcon_get_font(struct vc_data *vc, struct console_font *font)
if (font->width <= 8) {
j = vc->vc_font.height;
+ printk("ksize(fontdata)=%lu font->charcount=%d vc->vc_font.height=%d font->width=%u\n", ksize(fontdata), font->charcount, j, font->width);
for (i = 0; i < font->charcount; i++) {
memcpy(data, fontdata, j);
memset(data + j, 0, 32 - j);
@@ -2661,6 +2662,8 @@ static int fbcon_set_font(struct vc_data *vc, struct console_font *font,
size = h * pitch * charcount;
new_data = kmalloc(FONT_EXTRA_WORDS * sizeof(int) + size, GFP_USER);
+ if (new_data)
+ printk("ksize(new_data)=%lu h=%u pitch=%u charcount=%u font->width=%u\n", ksize(new_data), h, pitch, charcount, font->width);
if (!new_data)
return -ENOMEM;
----------
Normal usage:
[ 27.305293] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.328527] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.362551] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.385084] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.387653] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.417562] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.437808] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.440738] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.461157] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.495346] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.607372] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.655674] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.675310] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
[ 27.702193] ksize(new_data)=8192 h=16 pitch=1 charcount=256 font->width=8
syzbot's testcase:
[ 115.784893] ksize(new_data)=4096 h=10 pitch=1 charcount=256 font->width=8
[ 115.790269] ksize(fontdata)=4096 font->charcount=256 vc->vc_font.height=16 font->width=8
next prev parent reply other threads:[~2019-12-05 2:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0000000000002cfc3a0598d42b70@google.com>
2019-12-03 22:37 ` KASAN: slab-out-of-bounds Read in fbcon_get_font Daniel Vetter
2019-12-04 6:33 ` Dmitry Vyukov
2019-12-04 9:15 ` Daniel Vetter
2019-12-04 20:49 ` Andrey Ryabinin
2019-12-04 21:41 ` syzbot
2019-12-05 1:59 ` Tetsuo Handa [this message]
2019-12-05 10:13 ` Paolo Bonzini
2019-12-05 10:16 ` Dmitry Vyukov
2019-12-05 10:22 ` Paolo Bonzini
2019-12-05 10:31 ` Dmitry Vyukov
2019-12-05 10:53 ` Paolo Bonzini
2019-12-05 11:27 ` Dmitry Vyukov
2019-12-05 11:29 ` Paolo Bonzini
2019-12-05 10:41 ` Tetsuo Handa
2019-12-05 11:35 ` Dmitry Vyukov
2019-12-05 11:36 ` Dmitry Vyukov
2019-12-05 10:30 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912050159.xB51xuco020972@www262.sakura.ne.jp \
--to=penguin-kernel@i-love.sakura.ne.jp \
--cc=aryabinin@virtuozzo.com \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dvyukov@google.com \
--cc=ghalat@redhat.com \
--cc=gleb@kernel.org \
--cc=gwshan@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=kasan-dev@googlegroups.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=pbonzini@redhat.com \
--cc=ruscur@russell.cc \
--cc=sam@ravnborg.org \
--cc=serge@hallyn.com \
--cc=stewart@linux.vnet.ibm.com \
--cc=syzbot+4455ca3b3291de891abc@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=takedakn@nttdata.co.jp \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).