From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05B52C2D0C2 for ; Mon, 30 Dec 2019 19:20:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCCAC206CB for ; Mon, 30 Dec 2019 19:20:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="PY5Y+hA+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727642AbfL3TUn (ORCPT ); Mon, 30 Dec 2019 14:20:43 -0500 Received: from mail-ot1-f67.google.com ([209.85.210.67]:36521 "EHLO mail-ot1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727571AbfL3TUn (ORCPT ); Mon, 30 Dec 2019 14:20:43 -0500 Received: by mail-ot1-f67.google.com with SMTP id 19so34900889otz.3 for ; Mon, 30 Dec 2019 11:20:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=R2HUGNP1cgOAxLXKvlAf83qqvmp0LxZQcufLQgEdsSk=; b=PY5Y+hA+W0jSa/dQ/V6VYLCqV4AT5UTQYa/uE4RAwjVpydp7EBzIhqRGAY878mMDoN FHEaoDv3IAjYCnvd9HjkLIn3r6sFuOEkicnZT8ougvvck33aYYn/XTuQVKWU8PlFODAj 3x4ttGGQfDQLwU/9UX1Ht2WkvfJSLQPfQYkRo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=R2HUGNP1cgOAxLXKvlAf83qqvmp0LxZQcufLQgEdsSk=; b=Ab9OHHOBSuMr/hvJEnRGPaZxTbvWmbcYab4CYQ1pyMzMmDWW8ihzrnaaNzZMqRhas5 Z57rVNjz8Eooe2n/FO4bcUTKAaDP4T9Sbf8DpSiHCbe/JdWBf8FGHyCQytniElAlydBv jJwko7gAer1VciSN5ja5FnBF0Ptlgs1wfzdUDRShmUduEngP1E3/ZhIHmTdV7ovVJtL8 478A7mO2/s7zQHdGD4aSw6f+ocT1VQHmbpzSC5jb+HHwmKARbKhpfClKjJE9+BHYcrNs zrV0UpC6T32uKG/8sMs3Q75QtSXM1P7yHH+srmo11yiCbBnvdnhiwgyzFV6pi4UVjII4 vYEA== X-Gm-Message-State: APjAAAWvMuRy27xM9QjvThTDEdyihN7wPXYEawVMCCUVqJqOlrl94Uj/ +jQiFtHG5ZoiXcBBCEgblZ/Ftg== X-Google-Smtp-Source: APXvYqxU4Rafz9V1wbvaC2DEXCwxWLwK/+lXqX/YBMc6nhISNgTL6bIGnejZYe7KiLdWaMYtrkPCNw== X-Received: by 2002:a05:6830:2116:: with SMTP id i22mr79234563otc.0.1577733642201; Mon, 30 Dec 2019 11:20:42 -0800 (PST) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id u75sm9985380oie.15.2019.12.30.11.20.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Dec 2019 11:20:41 -0800 (PST) Date: Mon, 30 Dec 2019 11:20:39 -0800 From: Kees Cook To: KP Singh Cc: Andrii Nakryiko , open list , bpf , linux-security-module@vger.kernel.org, Alexei Starovoitov , Daniel Borkmann , James Morris , Thomas Garnier , Michael Halcrow , Paul Turner , Brendan Gregg , Jann Horn , Matthew Garrett , Christian Brauner , =?iso-8859-1?Q?Micka=EBl_Sala=FCn?= , Florent Revest , Brendan Jackman , Martin KaFai Lau , Song Liu , Yonghong Song , "Serge E. Hallyn" , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Nicolas Ferre , Stanislav Fomichev , Quentin Monnet , Andrey Ignatov , Joe Stringer Subject: Re: [PATCH bpf-next v1 06/13] bpf: lsm: Init Hooks and create files in securityfs Message-ID: <201912301119.B475C474@keescook> References: <20191220154208.15895-1-kpsingh@chromium.org> <20191220154208.15895-7-kpsingh@chromium.org> <20191230153711.GD70684@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191230153711.GD70684@google.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Mon, Dec 30, 2019 at 04:37:11PM +0100, KP Singh wrote: > On 23-Dec 22:28, Andrii Nakryiko wrote: > > On Fri, Dec 20, 2019 at 7:43 AM KP Singh wrote: > > [...] > > Good catch! You're right. These macros will not be there in v2 as > we move to using trampolines based callbacks. Speaking of which -- is the BPF trampoline code correctly designed to be W^X? -- Kees Cook