From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: KP Singh <kpsingh@chromium.org>
Cc: linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, bpf@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Paul Turner <pjt@google.com>, Jann Horn <jannh@google.com>,
Stephen Smalley <stephen.smalley.work@gmail.com>,
Florent Revest <revest@chromium.org>,
Brendan Jackman <jackmanb@chromium.org>
Subject: Re: [PATCH bpf-next] bpf: Remove unnecessary CAP_MAC_ADMIN check
Date: Thu, 5 Mar 2020 14:38:59 -0800 [thread overview]
Message-ID: <20200305223858.qprrtu6jfbaqt3bk@ast-mbp> (raw)
In-Reply-To: <20200305204955.31123-1-kpsingh@chromium.org>
On Thu, Mar 05, 2020 at 09:49:55PM +0100, KP Singh wrote:
> From: KP Singh <kpsingh@google.com>
>
> While well intentioned, checking CAP_MAC_ADMIN for attaching
> BPF_MODIFY_RETURN tracing programs to "security_" functions is not
> necessary as tracing BPF programs already require CAP_SYS_ADMIN.
>
> Fixes: 6ba43b761c41 ("bpf: Attachment verification for BPF_MODIFY_RETURN")
> Signed-off-by: KP Singh <kpsingh@google.com>
Applied. Thanks
prev parent reply other threads:[~2020-03-05 22:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 20:49 [PATCH bpf-next] bpf: Remove unnecessary CAP_MAC_ADMIN check KP Singh
2020-03-05 22:38 ` Alexei Starovoitov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200305223858.qprrtu6jfbaqt3bk@ast-mbp \
--to=alexei.starovoitov@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jackmanb@chromium.org \
--cc=jannh@google.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=pjt@google.com \
--cc=revest@chromium.org \
--cc=stephen.smalley.work@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).