From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92B5C2D0E6 for ; Wed, 25 Mar 2020 19:16:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 829022076F for ; Wed, 25 Mar 2020 19:16:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YdgTKJCI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727636AbgCYTQX (ORCPT ); Wed, 25 Mar 2020 15:16:23 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:36486 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727281AbgCYTQX (ORCPT ); Wed, 25 Mar 2020 15:16:23 -0400 Received: by mail-pf1-f195.google.com with SMTP id i13so1527953pfe.3 for ; Wed, 25 Mar 2020 12:16:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=/CSnYJ72yMBY5GskbXfCv8g/G/mmEEpCrCFQo2L0Aws=; b=YdgTKJCIKwSBYuNKrvm+Yt8937ehN0RPqPBaX9M9Q14Ku0AZPia/hqQDs58KLJaWqN BCJYs12445mr3vOefmZ1wZ1vBbhdQRVsbxjZFE/ES2F0BKD2p7LwqyVuo+e8WYYbpjW/ HtnNRacXs+AIqCrCJGVmVZJ1pHSbWBrGZ7boE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=/CSnYJ72yMBY5GskbXfCv8g/G/mmEEpCrCFQo2L0Aws=; b=ts/mRJNcCVuNtFvGhkIhraoTI+cVNu5Fm1iRYd1T7Pywf2Cf8eKoTc9QEOwZl8afSW ronb3HX6I0aai0iGsxO6MmwWHepNvAPRDuJgp79v96TfV6TaIGIK0YlsAvBmR2JBBgGH M6k/71K2mYrHGAggtTupDVM7pjtGzkkKINFGVaxZ+MQasTtXI1tI8zaKlqVjajjEBk1N 8PqYeRNxp4p553T64YHfi3t2Eh4aED1nPmP9KlL5+dGSNgJ5w7A5kUvFqWnyQ9k9VRRG dCYeWqCHjRDakAc2HCR7cKxTYRMPjAP6/b/naxqDpsz7ETlMyx/GOBLrB5x54WdLD+jO 8M3w== X-Gm-Message-State: ANhLgQ3IOxdn3jbAL1CU7rYh0Ube59HRzUixxMaiHKw37wrtsglW9Ek3 WGJCheKVOpTpq/lLkT2hIhQpRw== X-Google-Smtp-Source: ADFU+vts8MQmEy0Le/cZw5nvgMjV7AYmKwKdII/bapz+8OLjmUP6QyQ5BjIOyAlngVJq2+M5nE3q1w== X-Received: by 2002:a63:778e:: with SMTP id s136mr4408159pgc.155.1585163780203; Wed, 25 Mar 2020 12:16:20 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id 144sm19093396pfx.184.2020.03.25.12.16.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Mar 2020 12:16:18 -0700 (PDT) Date: Wed, 25 Mar 2020 12:16:17 -0700 From: Kees Cook To: Alexey Gladkov Cc: LKML , Kernel Hardening , Linux API , Linux FS Devel , Linux Security Module , Akinobu Mita , Alexander Viro , Alexey Dobriyan , Alexey Gladkov , Andrew Morton , Andy Lutomirski , Daniel Micay , Djalal Harouni , "Dmitry V . Levin" , "Eric W . Biederman" , Greg Kroah-Hartman , Ingo Molnar , "J . Bruce Fields" , Jeff Layton , Jonathan Corbet , Linus Torvalds , Oleg Nesterov Subject: Re: [PATCH v9 9/8] proc: use named enums for better readability Message-ID: <202003251216.FD5E296@keescook> References: <20200325174245.298009-1-gladkov.alexey@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200325174245.298009-1-gladkov.alexey@gmail.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Wed, Mar 25, 2020 at 06:42:45PM +0100, Alexey Gladkov wrote: > Signed-off-by: Alexey Gladkov I love these kinds of cleanups. :) Reviewed-by: Kees Cook -Kees > --- > fs/proc/base.c | 2 +- > fs/proc/inode.c | 2 +- > fs/proc/root.c | 4 ++-- > include/linux/proc_fs.h | 6 +++--- > include/uapi/linux/proc_fs.h | 2 +- > 5 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/fs/proc/base.c b/fs/proc/base.c > index a836979e42fe..608d60fb79fb 100644 > --- a/fs/proc/base.c > +++ b/fs/proc/base.c > @@ -699,7 +699,7 @@ int proc_setattr(struct dentry *dentry, struct iattr *attr) > */ > static bool has_pid_permissions(struct proc_fs_info *fs_info, > struct task_struct *task, > - int hide_pid_min) > + enum proc_hidepid hide_pid_min) > { > /* > * If 'hidpid' mount option is set force a ptrace check, > diff --git a/fs/proc/inode.c b/fs/proc/inode.c > index a462fd111719..7870e0be0a1f 100644 > --- a/fs/proc/inode.c > +++ b/fs/proc/inode.c > @@ -165,7 +165,7 @@ void proc_invalidate_siblings_dcache(struct hlist_head *inodes, spinlock_t *lock > deactivate_super(old_sb); > } > > -static inline const char *hidepid2str(int v) > +static inline const char *hidepid2str(enum proc_hidepid v) > { > switch (v) { > case HIDEPID_OFF: return "off"; > diff --git a/fs/proc/root.c b/fs/proc/root.c > index 42f3ee05c584..de7cee435621 100644 > --- a/fs/proc/root.c > +++ b/fs/proc/root.c > @@ -32,9 +32,9 @@ > struct proc_fs_context { > struct proc_fs_info *fs_info; > unsigned int mask; > - int hidepid; > + enum proc_hidepid hidepid; > int gid; > - int pidonly; > + enum proc_pidonly pidonly; > }; > > enum proc_param { > diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h > index d259817ec913..b9f7ecd7f61f 100644 > --- a/include/linux/proc_fs.h > +++ b/include/linux/proc_fs.h > @@ -29,7 +29,7 @@ struct proc_ops { > }; > > /* definitions for proc mount option pidonly */ > -enum { > +enum proc_pidonly { > PROC_PIDONLY_OFF = 0, > PROC_PIDONLY_ON = 1, > }; > @@ -39,8 +39,8 @@ struct proc_fs_info { > struct dentry *proc_self; /* For /proc/self */ > struct dentry *proc_thread_self; /* For /proc/thread-self */ > kgid_t pid_gid; > - int hide_pid; > - int pidonly; > + enum proc_hidepid hide_pid; > + enum proc_pidonly pidonly; > }; > > static inline struct proc_fs_info *proc_sb_info(struct super_block *sb) > diff --git a/include/uapi/linux/proc_fs.h b/include/uapi/linux/proc_fs.h > index dc6d717aa6ec..f5fe0e8dcfe4 100644 > --- a/include/uapi/linux/proc_fs.h > +++ b/include/uapi/linux/proc_fs.h > @@ -3,7 +3,7 @@ > #define _UAPI_PROC_FS_H > > /* definitions for hide_pid field */ > -enum { > +enum proc_hidepid { > HIDEPID_OFF = 0, > HIDEPID_NO_ACCESS = 1, > HIDEPID_INVISIBLE = 2, > -- > 2.25.2 > -- Kees Cook