From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 69D87C433E3 for ; Wed, 17 Jun 2020 15:36:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3B0A120CC7 for ; Wed, 17 Jun 2020 15:36:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592408212; bh=Ija7pWEEhwwlfG6l3Wt+WLYZWPuXJEBLmjFze1p/mOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=aB2Kmw5hTQjVyRhJcch/HLd6Q9St2inf0JjU/V9Wo3yKlNqY1oBuIf4fTVN/zrVOT SfIMNZoLuEfP08r9eZwvxGg2zkZVLQMOKLn6elPrpgFA3WnBu3EjU0dniNPo4P16pS FEuzLR7C1nkwUsnyqVcxkKyZ/xUxdeIadQUNqPXc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726861AbgFQPgr (ORCPT ); Wed, 17 Jun 2020 11:36:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:35058 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726758AbgFQPgr (ORCPT ); Wed, 17 Jun 2020 11:36:47 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7FAAC20890; Wed, 17 Jun 2020 15:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592408207; bh=Ija7pWEEhwwlfG6l3Wt+WLYZWPuXJEBLmjFze1p/mOs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WNnlKLwwT0RM/nS8LvP0duamjn8PGmfZ8D8Y3dFb1pg9qnV1/tZUXrw05Ts2gWas2 1YqSFmHq7FE61/q8ZQApKHBU6HXsAytxm2hiMMOsmXAyxriHINNQx2hwkrOZtv71ag Bds0At2fVG8yqPXF91y7bSa07XnMQtjvBl6Jtssg= Date: Wed, 17 Jun 2020 17:36:39 +0200 From: Greg Kroah-Hartman To: Scott Branden Cc: Christoph Hellwig , Luis Chamberlain , Alexander Viro , Eric Biederman , Jessica Yu , BCM Kernel Feedback , "Rafael J . Wysocki" , James Morris , "Serge E . Hallyn" , Mimi Zohar , Dmitry Kasatkin , Kees Cook , Paul Moore , Stephen Smalley , Eric Paris , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kexec@lists.infradead.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, selinux@vger.kernel.org Subject: Re: [PATCH v2 1/1] fs: move kernel_read_file* to its own include file Message-ID: <20200617153639.GA2702068@kroah.com> References: <20200617151710.16613-1-scott.branden@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617151710.16613-1-scott.branden@broadcom.com> Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Wed, Jun 17, 2020 at 08:17:10AM -0700, Scott Branden wrote: > Move kernel_read_file* out of linux/fs.h to its own linux/kernel_read_file.h > include file. That header gets pulled in just about everywhere > and doesn't really need functions not related to the general fs interface. > > Suggested-by: Christoph Hellwig > Signed-off-by: Scott Branden > --- > drivers/base/firmware_loader/main.c | 1 + > fs/exec.c | 1 + > include/linux/fs.h | 39 ---------------------- > include/linux/ima.h | 1 + > include/linux/kernel_read_file.h | 52 +++++++++++++++++++++++++++++ > include/linux/security.h | 1 + > kernel/kexec_file.c | 1 + > kernel/module.c | 1 + > security/integrity/digsig.c | 1 + > security/integrity/ima/ima_fs.c | 1 + > security/integrity/ima/ima_main.c | 1 + > security/integrity/ima/ima_policy.c | 1 + > security/loadpin/loadpin.c | 1 + > security/security.c | 1 + > security/selinux/hooks.c | 1 + > 15 files changed, 65 insertions(+), 39 deletions(-) > create mode 100644 include/linux/kernel_read_file.h What changed from v1? Always put that below the --- line. thanks, greg k-h