From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5C92C433E2 for ; Tue, 23 Jun 2020 00:56:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B09FD20720 for ; Tue, 23 Jun 2020 00:56:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732462AbgFWA4y (ORCPT ); Mon, 22 Jun 2020 20:56:54 -0400 Received: from mga07.intel.com ([134.134.136.100]:19664 "EHLO mga07.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731716AbgFWA4y (ORCPT ); Mon, 22 Jun 2020 20:56:54 -0400 IronPort-SDR: dMa1X1y+N2nnzvE1cG/Uc0kJ4HstZshT9Iqpa89XLTrmbyeEOTSZXmu2Wzs1HZlTn7G6DEXDR0 M+4FedR4LgNQ== X-IronPort-AV: E=McAfee;i="6000,8403,9660"; a="209105471" X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="209105471" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Jun 2020 17:56:53 -0700 IronPort-SDR: lPQvkJeKMRriPzHiopqrWej+qGnagrV1b1YED5Xmxo3yPIlTwlyqilTvzxHycxkWjyTZYKHmJF BReBbzD2SP9g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,268,1589266800"; d="scan'208";a="275175170" Received: from jczajka-mobl.ger.corp.intel.com (HELO localhost) ([10.249.40.133]) by orsmga003.jf.intel.com with ESMTP; 22 Jun 2020 17:56:48 -0700 Date: Tue, 23 Jun 2020 03:56:47 +0300 From: Jarkko Sakkinen To: Stefan Berger Cc: "Rafael J. Wysocki" , Stefan Berger , "Rafael J. Wysocki" , linux-integrity@vger.kernel.org, ACPI Devel Maling List , Linux Kernel Mailing List , linux-security-module@vger.kernel.org Subject: Re: [PATCH v3] acpi: Extend TPM2 ACPI table with missing log fields Message-ID: <20200623005647.GD28795@linux.intel.com> References: <20200331214949.883781-1-stefanb@linux.vnet.ibm.com> <20200401083729.GD17325@linux.intel.com> <20200402192145.GB10314@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: owner-linux-security-module@vger.kernel.org Precedence: bulk List-ID: On Fri, Jun 19, 2020 at 11:14:20AM -0400, Stefan Berger wrote: > On 4/2/20 3:21 PM, Jarkko Sakkinen wrote: > > On Wed, Apr 01, 2020 at 11:05:36AM +0200, Rafael J. Wysocki wrote: > > > On Wed, Apr 1, 2020 at 10:37 AM Jarkko Sakkinen > > > wrote: > > > > On Tue, Mar 31, 2020 at 05:49:49PM -0400, Stefan Berger wrote: > > > > > From: Stefan Berger > > > > > > > > > > Recent extensions of the TPM2 ACPI table added 3 more fields > > > > > including 12 bytes of start method specific parameters and Log Area > > > > > Minimum Length (u32) and Log Area Start Address (u64). So, we extend > > > > > the existing structure with these fields to allow non-UEFI systems > > > > > to access the TPM2's log. > > > > > > > > > > The specification that has the new fields is the following: > > > > > TCG ACPI Specification > > > > > Family "1.2" and "2.0" > > > > > Version 1.2, Revision 8 > > > > > > > > > > Adapt all existing table size calculations to use > > > > > offsetof(struct acpi_table_tpm2, start_method_specific) > > > > > [where start_method_specific is a newly added field] > > > > > rather than sizeof(struct acpi_table_tpm2) so that the addition > > > > > of the new fields does not affect current systems that may not > > > > > have them. > > > > > > > > > > Signed-off-by: Stefan Berger > > > > > Cc: linux-acpi@vger.kernel.org > > > > I think I'm cool with this but needs an ack from ACPI maintainer. > > > > > > > > Rafael, given that this not an intrusive change in any possible means, > > > > can I pick this patch and put it to my next pull request? > > > Yes, please. > > > > > > Thanks! > > Great, thanks Rafael. > > > > Reviewed-by: Jarkko Sakkinen > > > > Do you mind if I add your ack to the commit? > > > Any chance to get v4 applied? You should split the actbl3.h change to a separate patch and add 'Cc:' tag to Rafael to the commit message. /Jarkko